fix(CI): surface ESDK Java perf benchmark failures and tolerate shared config keys - #932
Merged
Merged
Conversation
…nfig keys The benchmark entrypoint swallowed all exceptions and exited 0, so CI reported success even when no results were produced and then uploaded the stale, checked-in java_results.json to CloudWatch. Print the stack trace and exit non-zero on failure. The root failure: Config could not deserialize the shared test-scenarios.yaml because it contains keys used by other language benchmarks (size_limits). Ignore unknown properties so the shared config loads.
Revert before merging. Lets this PR exercise the benchmark + CloudWatch upload so we can confirm the ESDK-Performance dashboard refreshes.
…ashboard" This reverts commit 5fa420e.
lucasmcdonald3
changed the title
josecorella
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Make the Java performance benchmark fail loudly (stack trace + non-zero exit) instead of swallowing exceptions, and let its config loader ignore unknown keys in the shared
test-scenarios.yaml.Squash/merge commit message, if applicable:
fix: surface ESDK Java perf benchmark failures and tolerate shared config keys
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.