Skip to content

refactor: split pipeline_runner_browser into focused mixins #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifuri-validator-agent merged 1 commit into from
Sep 1, 2026
Merged

refactor: split pipeline_runner_browser into focused mixins #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/nlp2cmd/pipeline_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ def run(
# This preserves backward compatibility: all imports of PipelineRunner still work.
from nlp2cmd.pipeline_runner_shell import ShellExecutionMixin # noqa: E402
from nlp2cmd.pipeline_runner_browser import BrowserExecutionMixin # noqa: E402
from nlp2cmd.pipeline_runner_browser_multi import BrowserMultiActionMixin # noqa: E402
from nlp2cmd.pipeline_runner_browser_dispatch import BrowserDispatchMixin # noqa: E402
from nlp2cmd.pipeline_runner_desktop import DesktopExecutionMixin # noqa: E402
from nlp2cmd.pipeline_runner_plans import PlanExecutionMixin # noqa: E402

Expand All @@ -175,6 +177,8 @@ def run(
class PipelineRunner( # type: ignore[no-redef]
ShellExecutionMixin,
BrowserExecutionMixin,
BrowserMultiActionMixin,
BrowserDispatchMixin,
DesktopExecutionMixin,
PlanExecutionMixin,
_BasePipelineRunner,
Expand All @@ -183,7 +187,9 @@ class PipelineRunner( # type: ignore[no-redef]

Mixins:
- ShellExecutionMixin: _run_shell, _parse_shell_command, _check_against_safety_policy
- BrowserExecutionMixin: _run_dom_dql, _run_dom_multi_action
- BrowserExecutionMixin: _run_dom_dql
- BrowserMultiActionMixin: _run_dom_multi_action
- BrowserDispatchMixin: _run_dom_multi_action_dispatch
- DesktopExecutionMixin: _dismiss_popups, _detect_desktop_backend,
_execute_desktop_plan_step, _xdotool_keys_to_ydotool, etc.
- PlanExecutionMixin: execute_action_plan, _execute_plan_step,
Expand Down
Loading
Loading