Skip to content

refactor: split pipeline_runner_browser into focused mixins - #3

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
refactor/pipeline-browser-dispatch-split
Sep 1, 2026
Merged

refactor: split pipeline_runner_browser into focused mixins#3
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
refactor/pipeline-browser-dispatch-split

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • Slim pipeline_runner_browser.py to single-action DOM entry (~114 lines)
  • Extract legacy _run_dom_multi_action to pipeline_runner_browser_multi.py
  • Extract ActionDispatcher path to pipeline_runner_browser_dispatch.py
  • Compose PipelineRunner from the three browser mixins

Test plan

  • CI passes (3.11, 3.12)
  • from nlp2cmd.pipeline_runner import PipelineRunner works

Made with Cursor

Extract legacy multi-action and ActionDispatcher paths into separate
modules; keep single-action DOM entry in pipeline_runner_browser.py.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head 5c6938d5169ed58b41c0b759fc13e18d5b40c7cd.

Ticket: ticket-000
Correlation ID: nlp2cmd-pr-3-ticket-000
Model: zai/glm-5.3
Advisory LLM review: LLM_UNAVAILABLE
Reason: advisory_review_budget_exceeded: full review requires 17 chunks; limit is 8
This approval rests on the deterministic checks alone; no advisory opinion was recorded for this head.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-000-1021
TICKET ticket-000
HEAD_SHA 5c6938d5169ed58b41c0b759fc13e18d5b40c7cd
CORRELATION_ID nlp2cmd-pr-3-ticket-000
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["test (3.11)=PASS","test (3.12)=PASS"]
INPUT required_checks = ["test (3.11)","test (3.12)"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = []
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 883842e into main Sep 1, 2026
2 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the refactor/pipeline-browser-dispatch-split branch September 1, 2026 11:59
@tom-sapletta-com
tom-sapletta-com restored the refactor/pipeline-browser-dispatch-split branch September 1, 2026 15:05
@tom-sapletta-com
tom-sapletta-com deleted the refactor/pipeline-browser-dispatch-split branch September 1, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant