Conversation
…ess communication of photon spectra
… or not they want to use IPC
Moved low level HDF5 functionality to a seperate HDF5Utils file in the utils directory. This has two main consequences. A: there are less HDF5 C API calls within the FispactProblem.C source file itself, making it slightly neater. B: Potentially easier testability of the HDF5 functionality, as different HDF5 mechanisms are now split into their own functions. As a result of reorganising the HDF5 reads/writes, one of the input parameters has changed. Previously, to read the neutron flux spectra from the OpenMC statepoint file, the user was asked to pass the internal HDF5 path to the required dataset as an input parameter to FispactProblem. This was janky. This has been changed so that now the user only need pass in the OpenMC tally id representing the energy binnedneutron flux spectra.
… method parameters
…aterials. Adds the capability to use FISPACT fuel, which allows for setting individual isotope quantities
Implement new system for defining FISPACTmaterials.
…oost installation requirement
…erly over the total mass of specified elements
…bol, and updated Makefile to depend on create fizzy executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A big PR that addresses issues #2 #5 #7 and #8.
This PR adds