Repository navigation
fix(governance): stop routing agents to retired settings tooling - #8
Merged
Merged
Conversation
The atrinik/github-settings publisher, audit and Project sync are retired. The governance skill no longer tells agents to run the publisher plan before --apply or to follow github-settings/AGENTS.md as a script runbook. It now points at that repository's current README and AGENTS.md, forbids the old bin/ scripts from its history, and describes hand changes under the owner's login: only when the task asks, exported first, re-read live and recorded in the same task. Correct the PR-only step range (3-5) and bump the plugin to 1.0.2. Co-Authored-By: Claude <noreply@anthropic.com>
Record the locally authored atrinik-github-governance/SKILL.md update from baseline 98196a5 to reviewed source fd2cf05, with its MIT license blob. Each local update path now admits exactly one reviewed (source, baseline) role pair; CI fetches the two new full commit IDs and expects three local records. PROVENANCE.md lists the new pair. Co-Authored-By: Claude <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
The current atrinik/github-settings tree, README and AGENTS.md still describe bin/publish and the other retired scripts until that repository's retirement PR merges. Ban its bin/ scripts by name from the current tree, an old checkout or a release, and drop the allowance for tools its README documents. Workflow changes no longer make Actions allowlist or ruleset edits a standing step: report the change they need and make it only when the task asks for it. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
Self-reviewReviewed by fresh-context independent reviewer subagents, given the intent brief. Round 0 - whole diff at
Round 1 - delta review of the fixes, at
Coverage note. Round 1 reviewed the code at the current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
atrinik-github-governanceskill still sent agents to the retiredatrinik/github-settingstooling. It told them to followgithub-settings/AGENTS.mdas a script runbook and to "run the publisher plan before--apply". The publisher, audit and Project sync are now retired. This PR rewrites the skill's settings guidance to match how settings are handled now, records the edit in the package provenance, and bumps the plugin to1.0.2.atrinik-issue-deliveryandatrinik-program-deliveryread the In progress status name fromgithub-settings/config/planning.json. That file stays inatrinik/github-settings, so those references keep working and are not changed. A new test pins them.Intent brief
SKILL.mdchanges. The two delivery skills need nothing that was retired: they set a Project status by hand and read one file that stays. Leaving them alone keeps the provenance change to a single record.README.mdandAGENTS.mdofatrinik/github-settingsfor the details instead of copying them. That follows this repository's rule that the owning repository holds operational authority. It also says the oldbin/scripts must not be run "even where older text still describes them", because that repository'sAGENTS.mdonmainstill documents the publisher until its own retirement PR merges.bin/scripts by name and wherever they are found: the current tree, an old checkout or a release. Onmaintoday itsREADME.mdandAGENTS.mdstill documentbin/publishand the planning scripts, so the skill gives no allowance for "tools its README documents". The planned read-only check (step 6 of the settings redesign) is not allowed yet; the PR that adds it must update this skill and its marker test (see Limitations / follow-up).local_authored_updatesentry, with source86ea824(the commit holding the finalSKILL.mdbytes) and baseline98196a5(currentmain). The offline validator now allows exactly one reviewed (source, baseline) pair per local path, in place of one global pair. The CI allowlist adds the two full commit IDs.1.0.2(patch): this corrects guidance and does not change any invocation policy or skill set.SKILL.mdtotal is well under 62,500). TheRequired checksandConventional PR titlejob names are unchanged.atrinik/github-settingsretirement PR itself, the planned read-only check and baselines, any GitHub settings, rulesets or secrets, and the disabledatrinik-development@zoey-localcopy.Implementation / behavior
skills/atrinik-github-governance/SKILL.md:README.md/AGENTS.mdofatrinik/github-settings, then compare them with the live API. The publisher, audit and Project sync are retired. Never run itsbin/scripts (publish*,audit,sync-projectand the rest), with or without--apply, from its current tree, an old checkout or a release, even where itsREADME.mdorAGENTS.mdstill describes them.skip steps 3–5; there are five steps).provenance.json: newlocal_authored_updatesrecord for that file (source/destination blobc0a5c17, baseline blob95cf884, MIT license blob).tests/test_package.py:LOCAL_UPDATE_ROLESmaps each local path to its one approved pair. A new test case refuses an approved revision that belongs to another path's pair. The manifest test expects1.0.2..github/workflows/validate.yml: the allowlist gains86ea824…and98196a5…, and three local records are expected.tests/test_imported_skill_contracts.py: asserts the new markers and the absence ofpublisher plan,github-settings/AGENTS.md,before `--apply`, the README-tools allowance and the standing allowlist update. It also checks that both delivery skills still cite`github-settings/config/planning.json`.PROVENANCE.md: lists the new reviewed pair.How the update reaches the machines
Nothing is published or released by hand. The Claude Code and Codex marketplaces that install
atrinik-developmenttrack this repository'smainbranch, so1.0.2reaches each machine when its client refreshes that marketplace after the merge.To get it sooner on a machine, refresh the marketplace that lists this plugin, update
atrinik-developmentfrom it, and start a new session (claude plugin marketplace update <marketplace>thenclaude plugin update atrinik-development@<marketplace>; for Codex,codex plugin marketplace upgrade <marketplace>). The installed version should then read1.0.2.The owner only needs to merge. The refresh is optional.
Validation
Local, from a fresh clone with the provenance objects fetched the way CI fetches them:
python3 -m unittest discover -v: 59 tests OK (Python 3.14), at head after the review fixespython3 -W error -m compileall -q -f tests: cleangit diff --check 98196a5: cleanCI runs the same checks on Python 3.11 and 3.13.
actionlintis not installed here. The workflow change only edits literals inside the existing Pythonrunblock.Limitations / follow-up
mainfetches86ea824by SHA from GitHub through this PR'srefs/pull/8/head, the same wayf723d04from docs(classic): align LLVM execution guidance #4 is served. Do not rewrite this branch's history up to86ea824. Any later edit to the governanceSKILL.mdneeds its source revision in the record moved to a commit that contains the final bytes.README.mdandAGENTS.mdstop describing the publisher. This PR is safe on its own either way: it bans those scripts by name even while they are still in the current tree.atrinik/github-settingsand a guidance paragraph telling agents to run it before and after every settings change. This skill's step 3 bans everybin/script of that repository, from its current tree too, andtests/test_imported_skill_contracts.pypins the marker "from its current tree, an old checkout or a release". Until this skill changes, the two instructions conflict. The step-6 work must therefore include a PR here that names the check as the one allowed tool (by path, read-only), keeps the ban on the retired scripts, updates that marker test, moves the provenance source revision to the new commit, and bumps the plugin version.upgraderefresh behaviour for a version bump cannot be confirmed until after the merge.🤖 Generated with Claude Code