Repository navigation
fix(governance): name the read-only settings check - #10
Merged
Merged
Conversation
Route settings, ruleset, Actions policy and required-check work to check_settings.py in atrinik/github-settings: run it before and after a change, stop on differences the task did not cause, and record the change in a baseline pull request there. Pin the new wording in the contract test. Co-Authored-By: Claude <noreply@anthropic.com>
Move the governance skill record to the new source commit with the current main as its baseline, approve that pair in CI, the tests and PROVENANCE.md, and bump the plugin to 1.0.3. Co-Authored-By: Claude <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Member
Author
Self-reviewReviewed head: cd7979d. How it was reviewed:
What was checked:
Findings: none. Fix commits: none. No commit was pushed after the reviewed head, so no delta review was needed. Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub governance skill now names the read-only settings check in
atrinik/github-settings. It says how to run it, when to run it, and wherethe record of a change goes. Before, the skill only said "compare with the
live GitHub API".
Intent brief
required-check work use
check_settings.pyand the baseline pull requestflow that
atrinik/github-settingsnow documents.(
python3 check_settings.py baselines/atrinik.json, run from a checkout ofatrinik/github-settings), its exit codes, "before and after any settingschange", and the baseline pull request. Point to its
README.mdfor therest instead of copying it, so the skill does not drift from it.
"(step 4)" stay correct. The check goes into step 4, next to the rule
about task-authorized changes.
it". The baseline does not hold every object in full (teams, Apps and
webhooks are names only), so the export is still the rollback record.
source commit, with the current
mainas its baseline. The validatorallows one record per path. The record's notes say that the baseline
already has the earlier retirement update from fix(governance): stop routing agents to retired settings tooling #8.
bin/scripts must not run, and thatconfig/planning.jsonis still readby skills stay unchanged. No live setting, workflow job name or invocation
policy changes.
atrinik/github-settings, other skills (noother skill routes settings work), and the PR stack reference.
Implementation / behavior
atrinik-github-governance/SKILL.md: step 3 lists rulesets, Actionspolicy and required checks, and drops the vague live API comparison.
Step 4 runs the check before and after a change, stops to report any
difference the task did not cause, runs a printed fix only when the task
authorizes that exact change, and records the change in the same task:
update
baselines/atrinik.jsonand open a pull request inatrinik/github-settingsthat quotes the check output and explains eachremaining line. The hand-off section says to rerun the check after the
baseline update and to name the baseline pull request.
tests/test_imported_skill_contracts.py: pins the new phrases and rejectsthe old "compare them with the live GitHub API" and "against a fresh live
read" wording.
provenance.jsonnow points tosource
c28a11dand baseline692c9a5. The same pair replaces86ea824/98196a5in the CI approval list,tests/test_package.pyandPROVENANCE.md.Validation
All commands from the README and the CI workflow, run locally after the
provenance objects were fetched:
python3 -m unittest discover -v: 59 tests, OK.python3 -W error -m compileall -q -f tests: OK.git diff --check: OK.Limitations / follow-up
c28a11dis a commit on this branch. After a squashmerge, CI fetches it from the public repository, as for fix(governance): stop routing agents to retired settings tooling #8.
README.mdandAGENTS.mdofatrinik/github-settingsatd0c9b67. If that flow changes, this skillneeds an update too.
🤖 Generated with Claude Code