Skip to content

fix(governance): name the read-only settings check - #10

Merged
zoeyrose merged 2 commits into
mainfrom
docs/governance-settings-check
Nov 15, 2026
Merged

zoeyrose merged 2 commits into
mainfrom
docs/governance-settings-check

Conversation

@zoeyrose

Copy link
Copy Markdown
Member

Summary

The GitHub governance skill now names the read-only settings check in
atrinik/github-settings. It says how to run it, when to run it, and where
the record of a change goes. Before, the skill only said "compare with the
live GitHub API".

Intent brief

  • Goal: agents that do settings, ruleset, Actions policy or
    required-check work use check_settings.py and the baseline pull request
    flow that atrinik/github-settings now documents.
  • Decision: name the check, its command
    (python3 check_settings.py baselines/atrinik.json, run from a checkout of
    atrinik/github-settings), its exit codes, "before and after any settings
    change", and the baseline pull request. Point to its README.md for the
    rest instead of copying it, so the skill does not drift from it.
  • Decision: keep the step numbers (steps 3–5), so "skip steps 3–5" and
    "(step 4)" stay correct. The check goes into step 4, next to the rule
    about task-authorized changes.
  • Decision: keep "Export each object the change touches before you change
    it". The baseline does not hold every object in full (teams, Apps and
    webhooks are names only), so the export is still the rollback record.
  • Decision: move the single provenance record for this skill to the new
    source commit, with the current main as its baseline. The validator
    allows one record per path. The record's notes say that the baseline
    already has the earlier retirement update from fix(governance): stop routing agents to retired settings tooling #8.
  • Constraints: the statements that the old tooling is retired, that its
    bin/ scripts must not run, and that config/planning.json is still read
    by skills stay unchanged. No live setting, workflow job name or invocation
    policy changes.
  • Out of scope: changes to atrinik/github-settings, other skills (no
    other skill routes settings work), and the PR stack reference.

Implementation / behavior

  • atrinik-github-governance/SKILL.md: step 3 lists rulesets, Actions
    policy and required checks, and drops the vague live API comparison.
    Step 4 runs the check before and after a change, stops to report any
    difference the task did not cause, runs a printed fix only when the task
    authorizes that exact change, and records the change in the same task:
    update baselines/atrinik.json and open a pull request in
    atrinik/github-settings that quotes the check output and explains each
    remaining line. The hand-off section says to rerun the check after the
    baseline update and to name the baseline pull request.
  • tests/test_imported_skill_contracts.py: pins the new phrases and rejects
    the old "compare them with the live GitHub API" and "against a fresh live
    read" wording.
  • Provenance: the governance record in provenance.json now points to
    source c28a11d and baseline 692c9a5. The same pair replaces
    86ea824/98196a5 in the CI approval list, tests/test_package.py and
    PROVENANCE.md.
  • Plugin version: 1.0.2 to 1.0.3 in both manifests, as in fix(governance): stop routing agents to retired settings tooling #8.

Validation

All commands from the README and the CI workflow, run locally after the
provenance objects were fetched:

  • python3 -m unittest discover -v: 59 tests, OK.
  • python3 -W error -m compileall -q -f tests: OK.
  • git diff --check: OK.

Limitations / follow-up

  • The source commit c28a11d is a commit on this branch. After a squash
    merge, CI fetches it from the public repository, as for fix(governance): stop routing agents to retired settings tooling #8.
  • The skill wording follows the README.md and AGENTS.md of
    atrinik/github-settings at d0c9b67. If that flow changes, this skill
    needs an update too.

🤖 Generated with Claude Code

zoeyrose and others added 2 commits November 14, 2026 21:13
Route settings, ruleset, Actions policy and required-check work to
check_settings.py in atrinik/github-settings: run it before and after a
change, stop on differences the task did not cause, and record the change
in a baseline pull request there. Pin the new wording in the contract test.

Co-Authored-By: Claude <noreply@anthropic.com>
Move the governance skill record to the new source commit with the
current main as its baseline, approve that pair in CI, the tests and
PROVENANCE.md, and bump the plugin to 1.0.3.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@zoeyrose

Copy link
Copy Markdown
Member Author

Self-review

Reviewed head: cd7979d.

How it was reviewed:

  • A fresh reviewer with no earlier context reviewed the whole diff from merge base 692c9a5 to cd7979d. The diff has 8 files.
  • The reviewer read AGENTS.md, CONTRIBUTING.md, the full governance skill, its openai.yaml, the pr-stack reference and the validate workflow.
  • The reviewer compared the skill text with the github-settings README and AGENTS.md on current main.

What was checked:

  • The provenance blobs are correct for the source, destination and baseline.
  • Commit c28a11d changes only the skill and its contract test.
  • No old commit or version reference is left. The version is 1.0.3 in both manifests and in the test.
  • The skill wording matches the settings check: the command, the exit codes, and running the check before and after a change.
  • The retired-tooling text and the bin/ ban are kept.
  • The diff has no private data and no host names.

Findings: none.

Fix commits: none. No commit was pushed after the reviewed head, so no delta review was needed.

Validation:

  • python3 -m unittest discover: 59 tests, OK.
  • python3 -W error -m compileall -q -f tests: OK.
  • git diff --check 692c9a5 HEAD: OK.
  • All CI checks on cd7979d passed.

@zoeyrose
zoeyrose marked this pull request as ready for review November 15, 2026 03:17
@zoeyrose zoeyrose self-assigned this Nov 15, 2026
@zoeyrose
zoeyrose requested a review from a team November 15, 2026 03:17
@zoeyrose
zoeyrose merged commit 2852c14 into main Nov 15, 2026
8 checks passed
@zoeyrose
zoeyrose deleted the docs/governance-settings-check branch November 15, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant