Skip to content

Fix 3863 #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Torxed merged 2 commits into from
Nov 1, 2025
Merged

Fix 3863 #3880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87c4f1b
Modify formatting warning text to be less scary
dgirtler Oct 21, 2025
fb8db22
Update
dgirtler Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions archinstall/lib/disk/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@ def perform_filesystem_operations(self, show_countdown: bool = True) -> None:
debug('No modifications required')
return

device_paths = ', '.join([str(mod.device.device_info.path) for mod in device_mods])

if show_countdown:
self._final_warning(device_paths)
self._final_warning()

# Setup the blockdevice, filesystem (and optionally encryption).
# Once that's done, we'll hand over to perform_installation()
Expand Down Expand Up @@ -337,10 +335,10 @@ def _lvm_vol_handle_e2scrub(self, vol_gp: LvmVolumeGroup) -> None:
Size(256, Unit.MiB, SectorSize.default()),
)

def _final_warning(self, device_paths: str) -> bool:
def _final_warning(self) -> bool:
# Issue a final warning before we continue with something un-revertable.
# We mention the drive one last time, and count from 5 to 0.
out = tr(' ! Formatting {} in ').format(device_paths)
out = tr('Starting device modifications in ')

@correctmost correctmost Oct 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the We mention the drive one last time, and count from 5 to 0. comment on line 340 should be updated too

Tui.print(out, row=0, endl='', clear_screen=True)

try:
Expand Down