Fix 3863 - #3880
Merged
Merged
Conversation
correctmost
reviewed
Oct 27, 2025
| # Issue a final warning before we continue with something un-revertable. | ||
| # We mention the drive one last time, and count from 5 to 0. | ||
| out = tr(' ! Formatting {} in ').format(device_paths) | ||
| out = tr('Starting device modifications in ') |
Contributor
There was a problem hiding this comment.
I think the We mention the drive one last time, and count from 5 to 0. comment on line 340 should be updated too
Torxed
approved these changes
Nov 1, 2025
|
thanks for the fix! well i thought i almost wiped my entire SSD which contains 9 partitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3863 and #2776
Change the final warning message from
Formatting in 1...2...3to something more generic as it's difficult to determine what each configuration may entail
Starting device modifications in 1...2...3