This repository was archived by the owner on Jun 13, 2023. It is now read-only.
[ruby] Upgrade rubocop to version 1.44.1#332
Closed
depfu[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closed in favor of #334. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.40.0 → ~> 1.44.1) · Repo · Changelog
Release Notes
1.44.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 21 commits:
Cut 1.44.1Update ChangelogFix typosMerge pull request #11493 from koic/fix_an_error_for_lint_voidUse `RuboCop::AST::Node#basic_conditional?`Use `RuboCop::AST::Node#operator_keyword?`[Fix #11492] Fix an error for `Lint/Void`Merge pull request #11488 from koic/fix_a_false_positive_for_lint_useless_assignmentMerge pull request #11487 from ydah/fix-false-positive-lint-format-parameter-mismatch-when-interpolated-stringMerge pull request #11490 from ydah/fix-indentFix an indentation for `Lint/HeredocMethodCallPosition` cop's documentationMerge pull request #11489 from ydah/add-docsAdd @example tag for `Lint/MixedRegexpCaptureTypes` in documentMerge pull request #11441 from ydah/use_rubocop-rspec-2.17Fix a false positive for `Lint/FormatParameterMismatch` when format string is only interpolated string[Fix #11485] Fix a false positive for `Lint/UselessAssignment`Merge pull request #11486 from fatkodima/fix-autocorrect-block_forwardingFix an incorrect autocorrect for `Naming/BlockForwarding`Merge pull request #11484 from fatkodima/fix-closing_parenthesis_indentationFix `Layout/ClosingParenthesisIndentation` for keyword splat argumentsSwitch back to dev versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands