This repository was archived by the owner on Jun 13, 2023. It is now read-only.
[ruby] Upgrade rubocop to version 1.44.0#331
Closed
depfu[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closed in favor of #332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.40.0 → ~> 1.44.0) · Repo · Changelog
Release Notes
1.44.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 70 commits:
Cut 1.44Update ChangelogAdd `Gemspec/DevelopmentDependencies` copAdd new `Style/InvertibleUnlessCondition` copChange to not output not configured warning when renamed and pending copMerge pull request #11480 from koic/fix_an_error_when_using_yaml_alias_with_server_modeMerge pull request #11481 from koic/remove_sbsolete_code_for_psychRemove obsolete code for Psych[Fix #11477] Fix an error when using YAML alias with server modeFix an error for `Style/Semicolon`[Fix #11350] Make `Lint/DeprecatedClassMethods` aware of deprecated `attr` methodFix crash with `super value_omission:` followed by a method callUpdate `Lint/Void` to suggest `each` in place of `map` or `collect` in void context.Make `Style/Semicolon` aware of redundant semicolon in blockAdd intentionally empty file to implicitly test cops on itMerge pull request #11456 from gsamokovarov/fix-yield-value-omissionAdd description to .pre-commit-hooks.yaml[Fix #11467] Fix a false negative for `Style/MethodCallWithoutArgsParentheses`Use `Corrector#swap` where possibleMerge pull request #11461 from koic/fix_an_error_for_style_operator_method_callMerge pull request #11464 from ydah/fix-false-negative-lint-format-parameter-mismatchFix a false negative for `Lint/FormatParameterMismatch` when include interpolated stringMerge pull request #11459 from splattael/lint-useless-ruby2-keywords-conditionMake `Metrics/CyclomaticComplexity` aware of pattern matchingMerge pull request #11457 from koic/make_metrics_block_nesting_aware_of_pattern_matching[Fix #11460] Fix an error for `Style/OperatorMethodCall`Make `Lint/UselessRuby2Keywords` aware of conditionsFix value omissions in `yield` invocationsMake `Metrics/BlockNesting` aware of pattern matching[Fix #11444] Fix a false positive for `Lint/ShadowingOuterLocalVariable`[Fix #11338] Add new `Style/ComparableClamp` copMerge pull request #11454 from fatkodima/redundant-todoMerge pull request #11453 from fatkodima/argument_type-from-astRemove stale TODOUse `Node#argument_type?` from `rubocop-ast`Merge pull request #11449 from koic/fix_an_incorrect_autocorrect_for_style_block_delimitersFix a build errorMake `InternalAffairs/RedundantLetRuboCopConfigNew` aware of a redundant `let`Merge pull request #11422 from koic/fix_a_false_positive_for_style_redundant_require_statemen[Fix #11445] Fix an incorrect autocorrect for `Style/BlockDelimiters`Make default indentation consistentMerge pull request #11447 from koic/fix_incorrect_autocorrect_for_style_redundant_double_splat_hash_bracesFix an incorrect autocorrect for `Style/RedundantDoubleSplatHashBraces`Fix an error for `Style/AccessModifierDeclarations`Merge pull request #11440 from ydah/fix/11439Merge pull request #11442 from gsamokovarov/fix-method-args-forwarding-crashFix a crash during anonymous rest argument forwarding[Fix #11439] Fix an incorrect autocorrect for `Style/MinMaxComparison` when using `a < b a : b` with `elsif/else`[Fix #11419] Fix a false positive for `Style/RedundantRequireStatement`Fix a crash in Style/HashSyntax[Fix #11434] Remove an erroneous `@api private` markMerge pull request #11435 from fatkodima/changelog-entry-lengthIncrease generated changelog entry's lengthMerge pull request #11433 from koic/fix_an_infinite_loop_error_for_layout_block_end_newline[Fix #11430] Fix an infinite loop error for `Layout/BlockEndNewline`Merge pull request #11428 from gsamokovarov/value-omission-in-superMerge pull request #11424 from koic/fix_a_false_positive_for_style_method_call_with_args_parenthesesMerge pull request #11417 from koic/fix_a_false_positive_for_lint_useless_method_definitionMerge pull request #11423 from koic/fix_a_false_positive_for_lint_useless_rescueApply value omission exceptions in super invocationsMerge pull request #11425 from krishanbhasin-shopify/kb/void-cop-spots-methods-that-take-blocksVoid context cop marks offense on nonmutating method that takes blockMerge pull request #11414 from koic/revert_github_actions_concurrencyApply concurrency for GHA workflow `pull_requests` envents only[Fix #11418] Fix a false positive for `Style/MethodCallWithArgsParentheses`[Fix #11420] Fix a false positive for `Lint/UselessRescue`Merge pull request #11388 from FnControlRuby/correctionImprove error messages for `expect_correction`.[Fix #11415] Fix a false positive for `Lint/UselessMethodDefinition`Switch back to dev versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands