fix: skip closed pull requests so they stay in Closed - #70
Merged
Merged
Conversation
apify-service-account
added
the
tested
apify-service-account
added
the
t-infra
Comment on lines
+84
to
+90
| /** | ||
| * Checks whether the pull request is closed, merged or not. | ||
| */ | ||
| public async isClosed(): Promise<boolean> { | ||
| const pullRequest = await this.getPullRequest(); | ||
| return pullRequest.state === 'closed'; | ||
| } |
Member
There was a problem hiding this comment.
so if it's merged instead of closed, how does this one behave please?
Author
There was a problem hiding this comment.
Merged PRs have state: closed in the REST API, so this returns true for both. Issue closing for merged PRs runs before this check
Member
There was a problem hiding this comment.
Sounds good, can you please extend the docstring so it explains this?
3 tasks
jirimoravcik
approved these changes
Sep 30, 2026
gippy
approved these changes
Sep 30, 2026
Member
|
Thanks for the fix guys! I didn't think of this situation originally, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a PR makes
github-webhooksset it to "Closed" and then re-run this action, which sets the team board status back to "Pull Request" a few seconds later (e.g. apify/apify-infra#1575).