Repository navigation
fix(seaweedfs): accept gRPC port suffix in master role probe - #3506
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #3506 +/- ##
===========================================
Coverage 0.00% 0.00%
===========================================
Files 72 72
Lines 7669 7669
===========================================
Misses 7669 7669 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ldming
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SeaweedFS 4.47 can serialize the master
Leaderaddress ashost:9333.19333, where the suffix is the optional gRPC port. The existing role probe only accepted addresses ending in:9333, so a healthy elected master could be reported asunknown.Change
host:9333andhost:9333.<grpcPort>addresses.IsLeaderis omitted or false.unknownfor malformed or non-numeric suffixes.This PR is based on the current
release-1.0head0d53cfeand supersedes the conflicting #3494 branch. The filer static-template fix is already present through merged PR #3493; this PR contains only the master role-probe fix and its tests.Validation
python3 -m unittest addons/seaweedfs/tests/test_scripts.py— 12/12KB_CRD_DIR=.../repos/kubeblocks/config/crd/bases python3 -m unittest addons/seaweedfs/tests/test_charts.py— 10/10shellspec --load-path ./shellspec --default-path addons/seaweedfs/scripts-ut-spec --shell bash— 1/1addons/seaweedfsandaddons-cluster/seaweedfsafter local dependency build — passedgit diff --check— passedTested commit:
e8f918d52a71da7198d406c110ce2f67db82f856.