Skip to content

fix(seaweedfs): accept gRPC port suffix in master role probe - #3494

Closed
weicao wants to merge 7 commits into
release-1.0from
fix/seaweedfs-master-grpc-role
Closed

weicao wants to merge 7 commits into
release-1.0from
fix/seaweedfs-master-grpc-role

Conversation

@weicao

@weicao weicao commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

SeaweedFS 4.47 serializes master Leader as host:9333.19333. The role probe required the address to end in :9333, so it returned unknown even for a valid leader or follower response. Accept an optional numeric gRPC port suffix while preserving plain HTTP addresses and rejecting missing hosts or malformed suffixes.

This child PR targets dev/seaweedfs-release-1.0 for #3493 and includes the static filer-template fix in its base (a403d79). The regression covers DNS and IPv4 addresses, a custom gRPC port, explicit and omitted IsLeader:false, and invalid address forms. The new tests first failed on the original script. After the fix, script tests 12/12, chart/schema checks 10/10, ShellCheck, and the ShellSpec entry passed. This is offline validation; runtime role-label convergence remains to be verified.

Sources: 4.47 ServerAddress constructor, status response, and addon role-probe contract.

@weicao
weicao requested review from a team and leon-ape as code owners September 19, 2026 12:37
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a403d79) to head (f434ad3).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev/seaweedfs-release-1.0   #3494   +/-   ##
=========================================================
  Coverage                       0.00%   0.00%           
=========================================================
  Files                             72      72           
  Lines                           7669    7669           
=========================================================
  Misses                          7669    7669           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from dev/seaweedfs-release-1.0 to release-1.0 September 20, 2026 07:10

@leon-ape leon-ape left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The chart advertises KubeBlocks >=1.0.0, but all six new ComponentDefinitions emit spec.podUpdatePolicy, which is absent from the released v1.0.0 and v1.0.1 CRDs. The PR's rendered-resource test fails against v1.0.0 with podUpdatePolicy was unexpected for each definition, while it passes against the newer pinned release-1.0 commit. Installations using strict schema validation on these advertised versions therefore reject the addon definitions.

@weicao

weicao commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by merged PR #3506, which contains the same SeaweedFS gRPC master role probe fix on release-1.0.

@weicao weicao closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants