Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/seaweedfs-release-1.0 #3494 +/- ##
=========================================================
Coverage 0.00% 0.00%
=========================================================
Files 72 72
Lines 7669 7669
=========================================================
Misses 7669 7669 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
left a comment
There was a problem hiding this comment.
P2: The chart advertises KubeBlocks >=1.0.0, but all six new ComponentDefinitions emit spec.podUpdatePolicy, which is absent from the released v1.0.0 and v1.0.1 CRDs. The PR's rendered-resource test fails against v1.0.0 with podUpdatePolicy was unexpected for each definition, while it passes against the newer pinned release-1.0 commit. Installations using strict schema validation on these advertised versions therefore reject the addon definitions.
|
Superseded by merged PR #3506, which contains the same SeaweedFS gRPC master role probe fix on release-1.0. |
SeaweedFS 4.47 serializes master
Leaderashost:9333.19333. The role probe required the address to end in:9333, so it returnedunknowneven for a valid leader or follower response. Accept an optional numeric gRPC port suffix while preserving plain HTTP addresses and rejecting missing hosts or malformed suffixes.This child PR targets
dev/seaweedfs-release-1.0for #3493 and includes the static filer-template fix in its base (a403d79). The regression covers DNS and IPv4 addresses, a custom gRPC port, explicit and omittedIsLeader:false, and invalid address forms. The new tests first failed on the original script. After the fix, script tests 12/12, chart/schema checks 10/10, ShellCheck, and the ShellSpec entry passed. This is offline validation; runtime role-label convergence remains to be verified.Sources: 4.47 ServerAddress constructor, status response, and addon role-probe contract.