Skip to content

fix: fixed decode buffer size estimate for BinaryViewArray #23765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liningpan wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Open

fix: fixed decode buffer size estimate for BinaryViewArray #23765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions datafusion/functions/src/encoding/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,10 @@ fn decode_array(array: &ArrayRef, encoding: Encoding) -> Result<ColumnarValue> {
}
DataType::BinaryView => {
let array = array.as_binary_view();
// Don't know if there is a more strict upper bound we can infer
// for view arrays byte data size.
encoding.decode_array::<_, i32>(&array, array.get_buffer_memory_size())
encoding.decode_array::<_, i32>(
&array,
array.lengths().map(|l| l as usize).sum::<usize>(),
)
}
DataType::LargeBinary => {
let array = array.as_binary::<i64>();
Expand Down Expand Up @@ -528,7 +529,7 @@ where

#[cfg(test)]
mod tests {
use arrow::array::BinaryArray;
use arrow::array::{ArrayBuilder, BinaryArray, BinaryViewBuilder};
use arrow_buffer::OffsetBuffer;

use super::*;
Expand All @@ -553,4 +554,14 @@ mod tests {
let size = estimate_byte_data_size(&array);
assert_eq!(size, 31);
}

#[test]
fn test_estimate_view_size() {
let mut builder = BinaryViewBuilder::new().with_deduplicate_strings();
for _ in 0..1000 {
builder.append_value([65u8; 64]);
}
let arr = ArrayBuilder::finish(&mut builder);
decode_array(&arr, Encoding::Base64).unwrap();
}
}
Loading