fix: fixed decode buffer size estimate for BinaryViewArray#23765
Open
liningpan wants to merge 1 commit into
Open
fix: fixed decode buffer size estimate for BinaryViewArray#23765liningpan wants to merge 1 commit into
liningpan wants to merge 1 commit into
Conversation
Author
|
@andygrove Could you please take a look at this bug/PR? I see you are working on the same function in a couple other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Previously, output buffer size may be underestimated if the BinaryViewArray is significantly deduplicated.
What changes are included in this PR?
Estimate size by adding up the length of each view.
Are these changes tested?
Yes
Are there any user-facing changes?
No