build: commit Gradle wrapper, drop CI bootstrap step#54
Open
InbalHoni wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for your contribution! The CI was disabled (because of the failures you are trying to fix). I re-enabled it, so if you could make some minor change (even the commit message) and repush, that should trigger it (I did see that it worked in your repository) |
Commit the pinned Gradle 5.6.4 wrapper (gradlew, gradlew.bat, wrapper jar and properties) and stop git-ignoring it, so building from a git checkout no longer requires bootstrapping.
14cddb4 to
87fbb7a
Compare
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The build currently provisions the Gradle wrapper at runtime via
gradle -b bootstrap.gradle. This relies on Gradle APIs that are deprecated and removed in Gradle 9, and the step has become a source of CI failures. To decouple git-checkout and CI builds from the bootstrap step, this change commits the pinned Gradle 5.6.4 wrapper directly to the repository.Changes
gradlew,gradlew.bat,gradle/wrapper/gradle-wrapper.jar,gradle/wrapper/gradle-wrapper.properties) and remove the corresponding.gitignoreentries, so./gradlewis available on a fresh checkout without bootstrapping.gradle -b bootstrap.gradlestep from thetestsandcodeql-analysisworkflows, which now invoke./gradlewdirectly.Source-release caveat
Per ASF policy, source-release tarballs must not contain binaries, so
release.gradlecontinues to exclude the wrapper from the source release. The bootstrap path for source releases is therefore intentionally unchanged here. Aligning the source-release flow will be addressed in a future PR/release as part of upgrading the Gradle version.Verification
Validated on a fork PR: both the
testsandcodeql-analysisworkflows pass with the committed wrapper and no bootstrap step.