build: commit Gradle wrapper, drop CI bootstrap step#1
Closed
InbalHoni wants to merge 2 commits into
Closed
Conversation
Commit the pinned Gradle 5.6.4 wrapper (gradlew, gradlew.bat, wrapper jar and properties) and stop git-ignoring it, so building from a git checkout no longer requires bootstrapping.
InbalHoni
force-pushed
the
feature/add-gradle-wrapper
branch
from
390e6a8 to
14cddb4
Compare
Owner
Author
|
Served its purpose — CI validated the change; superseded by upstream apache#54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits the pinned Gradle 5.6.4 wrapper and un-ignores it, so building from a git checkout no longer needs
gradle -b bootstrap.gradle; removes that step from the tests and CodeQL workflows.(Fork PR to exercise CI before opening the upstream PR to apache/datafu.)