Feature/ccm resource fix - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a Yosys inference issue by adding explicit resets in the CCM pipeline so DSP blocks are not optimized away, and updates the build/CI flow to run “full” simulation and synthesis on main to produce complete resource-usage artifacts for published documentation.
Changes:
- Reset CCM stage-2 pixel accumulator registers during reset to preserve DSP inference in Yosys.
- Add
SIM_SPEED/SYNTH_SPEEDMakefile parameters and wire them through CI, usingfullonmainandsimfastotherwise. - Add a README link pointing users to the hosted documentation (including resource usage stats).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rtl/ccm.sv | Adds reset assignments for stage-2 pixel accumulator registers to prevent Yosys from optimizing away DSP inference. |
| README.md | Adds a documentation link for resource usage statistics. |
| Makefile | Introduces SIM_SPEED / SYNTH_SPEED variables and uses them for sim/synth targets. |
| .github/workflows/cicd.yml | Sets speed based on branch and passes it to make sim / make synth so main runs full flows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yosys needs some pipe pixel to be reset in order to correctly infer the CCM DSPs.
Also, added full synthesis and simulation runs when merging to main, so that full resource usage statistics are available when the docs are main generated. Also added another link to the documentation in README.