Skip to content

ADR 0055: first issue without the remaining facts; weekly hand-off steps - #129

Merged
github-actions[bot] merged 4 commits into
mainfrom
claude/first-issue-handoff
Nov 16, 2026
Merged

github-actions[bot] merged 4 commits into
mainfrom
claude/first-issue-handoff

Conversation

@acarchidi

@acarchidi acarchidi commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

What changed

  • ADR 0055 records the owner's decisions of 2026-11-16 and 2026-10-26:
    • The first newsletter issue goes out without conference dates, development stage, pipeline pages and cohort size. Those follow as each one merges.
    • Each Monday a fresh coding session builds the free and paid pages and hands them to the owner privately.
    • Coding work runs in batches, and model-using product jobs run at most once a day.
    • ADR 0045's temporary merge rule ended: the Claude review returned a verdict again today.
  • This changes ADR 0045 decision 4. That decision promised one catch-up Claude review of main, covering every PR merged during the outage (2026-10-20 to 2026-11-16). It now waits for the owner's yes, because it costs roughly $5–15 of credit. The agent is asking the owner now.
  • New docs/weekly-issue.md: the exact Monday steps. They were tried today: a sealed export, then unseal, then both pages built (free: 1 rescheduled, 5 new, 25 upcoming; paid: 3, 21, 142).
  • Roadmap: the entry-facts note updated and a decision-log row added. "Weekly issue hand-off" stays unticked until the Monday schedule exists.
  • uv.lock: carries the opentelemetry-api 1.45.2 fix from Update opentelemetry-api for a new security advisory #130, so "Dependency audit" passes.

How it was tested

  • Docs plus the lockfile. The pre-commit hooks pass. pip-audit is clean on the lockfile. The steps in docs/weekly-issue.md are the ones run in this session for this week's test issue.
  • No test was edited.

Risks

  • None to code.

Needed from the owner

  • A yes or no on the catch-up review of main (about $5–15).
  • Before the first issue is published, CP7b needs your Substack test email (postal address and unsubscribe link).

Checkpoint

  • CP7b (first Substack issue). The separate Opus review of the issue-building code passed today with no blocking findings.

🤖 Generated with Claude Code

https://claude.ai/code/session_017BpEZ7pADxYXWW2RSSarAJ

…atched work

The owner chose on 2026-11-16 to send the first issue without conference
dates, development stage, pipeline pages and cohort size. docs/weekly-issue.md
gives the Monday steps that build the free and paid pages from the sealed
export and hand them over privately. Records batched work, once-daily product
jobs, and the end of ADR 0045's interim merge rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017BpEZ7pADxYXWW2RSSarAJ
@acarchidi
acarchidi marked this pull request as ready for review November 16, 2026 19:47
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Overseer: changes needed

From the check on this pull request.

This pull request adds ADR 0055, the Monday steps in docs/weekly-issue.md, and lines in the roadmap and its decision log. The earlier review's points are fixed: the ADR now says it changes ADR 0045 decision 4, the description asks the owner about the catch-up review, and the hand-off item stays unticked until the Monday schedule exists. But the branch has merged in the commit from open pull request #130 to get the library security fix, so it is built on another open pull request's work.

Must fix before merging

Notes

  • The uv.lock change also moves the lockfile's format number from 'revision = 5' back to 'revision = 3'. Neither description mentions this. It probably comes from an older uv version, and Update opentelemetry-api for a new security advisory #130 makes the same change. Check that the uv version CI uses still reads the file without rewriting it.
  • CI's 'Lint, types, tests, migrations', 'Dependency audit' and 'Secret scan' checks are not yet shown on the latest commit. Only the Claude review and Overseer were running when this check ran.
  • The description has no 'Roadmap item and checkpoint' heading and no checklist from the pull request template. The item and CP7b are named in other sections.
  • The item comes from the owner's decisions recorded on 2026-11-16, so taking it ahead of earlier unticked roadmap items fits the rules. No owner-only files, code or tests are changed.

A blocking finding counts like a blocking review comment: fix it, or explain on this pull request why not, and the owner settles it (ADR 0019).

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude review: passed

This pull request records the owner's decisions to send the first newsletter without the four remaining facts, writes down the Monday steps for building each issue privately, and carries a security fix for one library. The steps refer to commands and workflow settings that already exist, and they keep the paid page, the export, and the key private. No code, test, check, or spending limit changes. I found nothing blocking; a few small notes are listed below.

Optional

  • docs/roadmap.md:208: The new decision-log line is labelled "(owner decisions)" and says ADR 0045 ended, but it does not mention that ADR 0055 also changes ADR 0045 decision 4. That catch-up review of main used to be automatic and now waits for the owner's yes. The change came from the agent, not from an owner decision. The PR description and the ADR both say this clearly; the log line should say it too.
  • docs/adr/0045-agent-merges-while-the-review-is-down.md:19: ADR 0045 decision 4 still says the agent runs the catch-up review of main, and nothing in that file points to ADR 0055. Someone reading only ADR 0045 would not know the review now waits for the owner's answer. A one-line "amended by ADR 0055" note would fix that, in its own small PR if this file is on the list the robot leaves for the owner.
  • uv.lock:2: The lockfile's format number drops from 5 to 3, probably because an older version of uv rewrote it. It still works, but other tools may keep switching the number back and forth. Regenerating it with the uv version CI uses would avoid that.
  • docs/weekly-issue.md:3: Step 3 downloads the whole job log into the scratchpad, and step 7 deletes it, so that is fine. The doc says every file stays at mode 600, but only the key and the export get an explicit chmod. The log and the two pages would be created with default permissions.

@github-actions
github-actions Bot merged commit 349bbeb into main Nov 16, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants