Repository navigation
Conversation
Placement review scored the irrigation controller 100 with SW1 24 mm from U1. Anchoring an unhinted button was measured to break the Routability Gate, so the placer is not steered. The description now lists a warning and a place_reset_button_near_mcu recommendation for any switch wired to an MCU, directly or through one resistor or capacitor, more than 15 mm from it. It does not set requires_revision, which would block routing on sensor_logger, whose button is 30 mm away.
An irrigation board came out with its crystal 17.8 mm from the MCU and its reset button 14.9 mm, both under the 15 mm the first version allowed. A crystal's load capacitors sit beside it, so its distance from the MCU is the length of the oscillator traces. The limit is 10 mm for both, and a crystal wired to an MCU now gets a place_crystal_near_mcu recommendation beside the reset button's. Still advice only: requires_revision stays false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix
What does this do?
describe_placementwarns and recommendsplace_reset_button_near_mcuorplace_crystal_near_mcuwhen one sits over 10 mm from its MCU.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes,
a_distant_reset_button_is_advised_against_but_does_not_blockonsensor_logger.Did you document any new/modified features?
No, the recommendation is self-describing in the placement result.
Notes
Advice only;
requires_revisionstays false becausesensor_loggerrouting depends on the button's position.