Repository navigation
NOISSUE - Update reference golden fingerprints from CI - #116
Merged
Merged
Conversation
nyagamunene
changed the title
CI draws every reference schematic about 19 paths away from the committed fingerprint, so golden_svg fails on the first design it compares. All ten fingerprints are copied from the CI log of run 38181427686 (main base), not regenerated locally. Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene
force-pushed
the
fix-battery-charger-golden
branch
from
October 11, 2026 23:17
e818989 to
bf21a18
Compare
JeffMboya
added a commit
to JeffMboya/synth
that referenced
this pull request
Oct 12, 2026
Both depend on KiCad symbol geometry, so they can only come from a run that has those libraries. These are CI's own numbers. All ten golden SVG fingerprints moved by exactly nineteen paths with their text counts unchanged — a uniform shift, so not design-specific. `main` is red on the same thing at 79daf6f and absmach#116 is the fix in flight there; this branch inherited it and the values here are what this branch's own run measured. If absmach#116 lands first the overlap resolves to whichever is live then. `env_logger_layout` lost a wire and gained the two RX labels it had been drawn as, the mirror of the change `sensor_logger` took earlier. The labels are inserted where the run's name-then-coordinate order puts them, without re-sorting the rest: an earlier attempt re-sorted the whole block and moved two CC labels, which would have encoded a different order from the one the layouter emits.
JeffMboya
added a commit
to JeffMboya/synth
that referenced
this pull request
Oct 12, 2026
…elines `keywords_recognized` lexes a fixed source and compares the whole token stream, so adding `match_length` to that source without adding `KwMatchLength` to the expected list failed it. Another guard worth having: the keyword vocabulary cannot grow silently. The two schematic baselines are CI's own numbers from this branch's run, because both depend on KiCad symbol geometry this machine does not have. All ten golden fingerprints moved — `main` is red on the same drift at 79daf6f and absmach#116 is the fix in flight there — and the feather placement moved by hundredths of a millimetre, which is the corrected oscillator courtyard propagating to its neighbours. Every old value in the placement snapshot was checked against the file before being replaced. An earlier attempt at this skipped that and had crossed two snapshot regions in the log, which would have written numbers no run ever produced into a release baseline.
JeffMboya
added a commit
to JeffMboya/synth
that referenced
this pull request
Oct 12, 2026
Both depend on KiCad symbol geometry, so they can only come from a run that has those libraries. These are CI's own numbers. All ten golden SVG fingerprints moved by exactly nineteen paths with their text counts unchanged — a uniform shift, so not design-specific. `main` is red on the same thing at 79daf6f and absmach#116 is the fix in flight there; this branch inherited it and the values here are what this branch's own run measured. If absmach#116 lands first the overlap resolves to whichever is live then. `env_logger_layout` lost a wire and gained the two RX labels it had been drawn as, the mirror of the change `sensor_logger` took earlier. The labels are inserted where the run's name-then-coordinate order puts them, without re-sorting the rest: an earlier attempt re-sorted the whole block and moved two CC labels, which would have encoded a different order from the one the layouter emits.
JeffMboya
added a commit
to JeffMboya/synth
that referenced
this pull request
Oct 12, 2026
…elines `keywords_recognized` lexes a fixed source and compares the whole token stream, so adding `match_length` to that source without adding `KwMatchLength` to the expected list failed it. Another guard worth having: the keyword vocabulary cannot grow silently. The two schematic baselines are CI's own numbers from this branch's run, because both depend on KiCad symbol geometry this machine does not have. All ten golden fingerprints moved — `main` is red on the same drift at 79daf6f and absmach#116 is the fix in flight there — and the feather placement moved by hundredths of a millimetre, which is the corrected oscillator courtyard propagating to its neighbours. Every old value in the placement snapshot was checked against the file before being replaced. An earlier attempt at this skipped that and had crossed two snapshot regions in the log, which would have written numbers no run ever produced into a release baseline.
JeffMboya
added a commit
to JeffMboya/synth
that referenced
this pull request
Oct 12, 2026
…elines `keywords_recognized` lexes a fixed source and compares the whole token stream, so adding `match_length` to that source without adding `KwMatchLength` to the expected list failed it. Another guard worth having: the keyword vocabulary cannot grow silently. The two schematic baselines are CI's own numbers from this branch's run, because both depend on KiCad symbol geometry this machine does not have. All ten golden fingerprints moved — `main` is red on the same drift at 79daf6f and absmach#116 is the fix in flight there — and the feather placement moved by hundredths of a millimetre, which is the corrected oscillator courtyard propagating to its neighbours. Every old value in the placement snapshot was checked against the file before being replaced. An earlier attempt at this skipped that and had crossed two snapshot regions in the log, which would have written numbers no run ever produced into a release baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's shard 1 fails in
golden_svg(e.g. https://github.com/absmach/synth/actions/runs/38123330349, the #111 merge). CI draws every reference schematic about 19 paths away from the committed fingerprint (ref_battery_charger: 6115 paths vs 6134), and the test stops at the first mismatch. Same failure on #102, #108, #110, #115.Changes
fixtures/kicad-reference/svg/golden.jsononly: all ten fingerprints copied from the CI log of run 38181427686 (main base), not regenerated locally. An intermediate commit that printed all live hashes was reverted.