Repository navigation
Conversation
Root seed for an unseeded CrystalPotential (abTEM#508), the TransmissionFunction rebuild, lazy dtype declarations, and the unit built once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entries for abTEM#524, which is still open and stacked on abTEM#506. The changelog lists only changes that are merged into
dev, so this should merge after abTEM#524 does.Entries
Under
Bugfixes::CrystalPotentialwithoutseedsdraws one crystal per simulation, from a root seed (closes abTEM#508). The entry says what determines the crystal and what independent crystals need.TransmissionFunctioncould not be run through multislice, sliced or loaded, andPotentialArray.transmission_functiondropped exit planes, ensemble axes and metadata. v1.0.10 has the same defect.Waves.dtypereporting the array's dtype, and the cast to the configured precision at the start ofWaves.multisliceandWaves.transition_potential_multislice.Under
Performance::CrystalPotentialbuilds its unit once per simulation instead of once per member and lazy scan block.abTEM#524 also stops
import abtemfrom loading cuBLAS. That has no entry: the extra import came in after v1.0.10, so no release is affected.🤖 Written and posted by Claude Code on Paul's behalf