Repository navigation
Conversation
Seven fixes from abTEM#556 that a user of v1.0.10 can hit, with the two changes in results (integrate_gradient offset, block_direct default radius) marked as behaviour changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entries for abTEM#556, which is still open. The changelog lists only changes that are merged into
dev, so this should merge after abTEM#556 does.Entries
One bullet under
Bugfixes:, after the multi-GPU hardening entry, with a sub-bullet per fix, as for abTEM#346 and in #36. The two changes in results come first and start with Behaviour change:.Images.integrate_gradientshifts each image of an ensemble so that its own minimum is 0; eager ensembles shared one constant before, and lazy results depended on the chunking. Single images are unchanged.DiffractionPatterns.block_direct()without asemiangle_cutoffblocks only the zero-angle pixel (radius half the smaller angular sampling) instead of also the neighbouring pixels, which are the first-order reflections of a one-cell pattern. The entry also states themargin=Truecase that blocks fewer pixels than before.Waves.normalize()raisedAttributeError; it now gives the eager result for any chunking.SMatrix.build()storedcomplex64plane waves underfloat64; it now follows the configured precision. The entry notes the doubled memory of the eager S-matrix, on the device or on the host, underfloat64.SMatrix.build()withstore_on_host=TrueraisedAttributeErroron the CPU device.GPAWPotentialof a single calculator with anAtomsEnsembleorEnergyResolvedAtomsEnsembleraises aValueErrorat construction (abTEM#538). The open question of abTEM#538, whether to support it, is not in the entry.The arithmetic entry describes the CuPy operand handling as abTEM#556 builds it. abTEM#556 asks the maintainer whether host operands should be moved to the device or refused with an error naming
copy_to_device, and it leaves open the asymmetry that a CPU measurement on the left of a GPU one still raisesTypeError. The entry follows the outcome of that question and is changed here if the design changes.Fixes without an entry
None: all seven fixes can be hit on
v1.0.10(EnergyResolvedAtomsEnsemble, named in theGPAWPotentialentry, is new in 1.1.0 and has the same defect ondev). abTEM#556 also describes two behaviours it leaves as they are, so they have no entry: the dtype a lazynormalize()declares, and the float32 result of a NumPy-scalar operand on CuPy data.The Bugfixes section ends at the same place in #35 and #36, so whichever of the three merges second needs a trivial rebase of the insertion point.
🤖 Written by Claude Code — Paul reviewed and posted it