Repository navigation
docs(adr): mark ADR-0002 and ADR-0003 as amended by ADR-0005 - #103
Merged
Merged
Conversation
TOMOKI977
approved these changes
Oct 6, 2026
TOMOKI977
left a comment
Contributor
There was a problem hiding this comment.
Approved. Every ADR-0002/ADR-0003 row of the ADR-0005 amendments table has a matching note at the right section, and the diff is purely additive.
One small nit: the doc comment on authorize_feedback says "Amended by ADR-0005 D5", but the ADR-0005 table marks that part as Superseded. Worth aligning the wording so the two don't disagree.
Deploying puls3 with
|
| Latest commit: |
b3ee6c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efef606c.puls3-4lw.pages.dev |
| Branch Preview URL: | https://docs-75-adr-amendments.puls3-4lw.pages.dev |
Contributor
|
@fercodes merged into I had to update the branch from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Summary
Adds amendment notes to
docs/adr/0002-agent-registry-on-soroban.mdanddocs/adr/0003-payment-rail-and-custody.mdso every row of ADR-0005's "What this supersedes or amends" table maps to a note at the affected section, naming the decision ID (D1/D2/D4/D5) and whether the section is superseded or amended. Original decision text is unchanged; the diff is additions-only.Acceptance criteria
Verification evidence
Notes added (decision ID / status):
authorize_feedback(D5, superseded)#55consequence row (D1, superseded); alternative 3 (D1, superseded); decisions 4–5 (unchanged)docs/adr/0005-align-agent-commerce-with-erc-8183-and-erc-8004.md→#what-this-supersedes-or-amendsNotes for reviewers
Docs-only change, so no component CI jobs apply. Out of scope per #75: rewriting the ADRs, the #74 Identity Registry gap review, the #14 redesign, and ADR-0001/vision updates.