Skip to content

docs(openspec): archive merged escrow changes and sync escrow specs - #104

Merged
moises-cisneros merged 2 commits into
mainfrom
docs/openspec-archive-escrow-changes
Oct 6, 2026
Merged

moises-cisneros merged 2 commits into
mainfrom
docs/openspec-archive-escrow-changes

Conversation

@moises-cisneros

Copy link
Copy Markdown
Contributor

Summary

Versions OpenSpec artifacts of changes that are already merged, so they stop living as untracked files:

Docs only. No code, no generated files.

Not included

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying puls3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7e2d78
Status: ✅  Deploy successful!
Preview URL: https://a55d90f8.puls3-4lw.pages.dev
Branch Preview URL: https://docs-openspec-archive-escrow.puls3-4lw.pages.dev

View logs

@moises-cisneros
moises-cisneros force-pushed the docs/openspec-archive-escrow-changes branch from 024c737 to 740b50e Compare October 6, 2026 15:37
Archive agent-escrow-payment (#55, PR #78), enforce-max-fee-bps (#79, PR #94)
and address-testnet-deploy-pr-review (PR #84), all merged. Add the
agent-escrow-lifecycle and agent-escrow-administration main specs.

@TOMOKI977 TOMOKI977 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The agent-escrow-administration main spec correctly merges the #55 delta with the #94 changes (MAX_FEE_BPS = 1,000 matches contracts/contracts/escrow/src/lib.rs), and dropping the resolved fee-cap open item makes sense.

Two small follow-ups, non-blocking:

  • A8 gained a new scenario ("successful admin change emits event") that isn't in either delta. Fine if intentional, but specs should only carry what a change actually specified, so either note where it came from or drop it.
  • agent-escrow-lifecycle still uses ### R1. create_job style headers, while the administration spec uses ### Requirement: A1.. OpenSpec expects ### Requirement:, so openspec validate will likely complain about the lifecycle spec.

@moises-cisneros moises-cisneros added the documentation Improvements or additions to documentation label Oct 6, 2026
- use '### Requirement:' headers in agent-escrow-lifecycle
- drop A8 scenario not present in any delta
@moises-cisneros
moises-cisneros merged commit 060c954 into main Oct 6, 2026
8 checks passed
@moises-cisneros
moises-cisneros deleted the docs/openspec-archive-escrow-changes branch October 6, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants