Repository navigation
docs(openspec): archive merged escrow changes and sync escrow specs - #104
Merged
Merged
Conversation
Deploying puls3 with
|
| Latest commit: |
a7e2d78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a55d90f8.puls3-4lw.pages.dev |
| Branch Preview URL: | https://docs-openspec-archive-escrow.puls3-4lw.pages.dev |
moises-cisneros
force-pushed
the
docs/openspec-archive-escrow-changes
branch
from
October 6, 2026 15:37
024c737 to
740b50e
Compare
TOMOKI977
approved these changes
Oct 6, 2026
TOMOKI977
left a comment
Contributor
There was a problem hiding this comment.
Approved. The agent-escrow-administration main spec correctly merges the #55 delta with the #94 changes (MAX_FEE_BPS = 1,000 matches contracts/contracts/escrow/src/lib.rs), and dropping the resolved fee-cap open item makes sense.
Two small follow-ups, non-blocking:
- A8 gained a new scenario ("successful admin change emits event") that isn't in either delta. Fine if intentional, but specs should only carry what a change actually specified, so either note where it came from or drop it.
agent-escrow-lifecyclestill uses### R1. create_jobstyle headers, while the administration spec uses### Requirement: A1.. OpenSpec expects### Requirement:, soopenspec validatewill likely complain about the lifecycle spec.
- use '### Requirement:' headers in agent-escrow-lifecycle - drop A8 scenario not present in any delta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Versions OpenSpec artifacts of changes that are already merged, so they stop living as untracked files:
agent-escrow-payment(feat: Agent Escrow and Payment contract on Soroban #55, merged in feat(contracts): add agent escrow and payment contract on Soroban #78). Task 5.1 (ADR-0003 amendment note) stays unchecked: it is tracked in docs(adr): mark ADR-0002 and ADR-0003 as amended by ADR-0005 #103.enforce-max-fee-bps(chore(contracts): enforce a hard MAX_FEE_BPS ceiling in the escrow #79, merged in feat: enforce max fee bps (#79) #94).address-testnet-deploy-pr-review(merged in chore(contracts): deploy escrow on testnet and document verifiable on-chain evidence #84).agent-escrow-lifecycle(from the feat: Agent Escrow and Payment contract on Soroban #55 delta) andagent-escrow-administration(already includes the feat: enforce max fee bps (#79) #94 modifications).Docs only. No code, no generated files.
Not included
escrow-claimable-ttl-evaluator-guard(fix(contracts): extend Claimable TTL and reject evaluator == provider in escrow #95 is still open, exploration and proposal only).hire-pay-endpointandopenspec/config.yaml: they ship with feat(server): hire and pay endpoint with on-chain payment verification #93.