Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Xcodes/Frontend/XcodeList/MainToolbar.swift
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ struct MainToolbarModifier: ViewModifier {
.tag(XcodeListCategory.release)
Label("BetaOnly", systemImage: "line.horizontal.3.decrease.circle.fill")
.tag(XcodeListCategory.beta)
Label("ReleasePlusNewBetas", systemImage: "line.horizontal.3.decrease.circle.fill")
.tag(XcodeListCategory.releasePlusNewBetas)
}
}
.help("FilterAvailableDescription")
Expand Down
4 changes: 3 additions & 1 deletion Xcodes/Frontend/XcodeList/XcodeListCategory.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ enum XcodeListCategory: String, CaseIterable, Identifiable, CustomStringConverti
case all
case release
case beta
case releasePlusNewBetas

var id: Self { self }

Expand All @@ -13,14 +14,15 @@ enum XcodeListCategory: String, CaseIterable, Identifiable, CustomStringConverti
case .all: return localizeString("All")
case .release: return localizeString("Release")
case .beta: return localizeString("Beta")
case .releasePlusNewBetas: return localizeString("ReleasePlusNewBetas")
}
}

var isManaged: Bool { PreferenceKey.xcodeListCategory.isManaged() }

var versionFilter: XcodeListVersionFilter {
switch self {
case .all:
case .all, .releasePlusNewBetas:
return .all
case .release:
return .release
Expand Down
21 changes: 20 additions & 1 deletion Xcodes/Frontend/XcodeList/XcodeListView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct XcodeListView: View {
}

private var visibleXcodes: [XcodeListEntry] {
appState.allXcodes
let entries = appState.allXcodes
.enumerated()
.map { XcodeListEntry(index: $0.offset, xcode: $0.element) }
.applying(XcodeListFilters(
Expand All @@ -31,6 +31,19 @@ struct XcodeListView: View {
searchText: searchText,
installedOnly: isInstalledOnly
), item: \.listItem)

if category == .releasePlusNewBetas {
let releases = Set(
entries
.filter { $0.xcode.version.isNotPrerelease }
.map { $0.xcode.version.withoutIdentifiers }
)
return entries.filter {
$0.xcode.version.isNotPrerelease || !releases.contains($0.xcode.version.withoutIdentifiers)
}
} else {
return entries
}
}

private func latestReleaseForSelectedPrerelease(_ xcode: Xcode) -> Xcode? {
Expand Down Expand Up @@ -437,3 +450,9 @@ struct XcodeListView_Previews: PreviewProvider {
.previewLayout(.sizeThatFits)
}
}

private extension Version {
var withoutIdentifiers: Version {
Version(major, minor, patch)
}
}
13 changes: 12 additions & 1 deletion Xcodes/Resources/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -22136,6 +22136,17 @@
}
}
},
"ReleasePlusNewBetas" : {
"extractionState" : "manual",
"localizations" : {
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "Release & unreleased beta"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure the best wording for this if you have better suggestions!

}
}
}
},
"Required" : {
"localizations" : {
"ar" : {
Expand Down Expand Up @@ -26217,4 +26228,4 @@
}
},
"version" : "1.0"
}
}