Add releasePlusNewBetas XcodeListCategory#403
Conversation
This adds a new filter option that shows only releases, plus any betas that do not have a release version. So as of today (July 7, 2023 the Xcode 15 betas will be shown but the Xcode 14 betas won't. Note that this will also show betas for older Xcode versions if necessary, for example if an Xcode 14.3.2 beta is released it will be shown until the mainline Xcode 14.3.2 is released.
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
Thanks for spending the time! I like the idea - just some clean up to make it compile and the localization string.
| .labelStyle(TitleOnlyLabelStyle()) | ||
| .foregroundColor(.accentColor) | ||
| } | ||
| case .releasePlusBeta: |
There was a problem hiding this comment.
There's some errors here around the name. Looks like you may have changed around the enum name and it's invalid here.
| } | ||
| case .releasePlusBeta: | ||
| if #available(macOS 11.3, *) { | ||
| Label("ReleasePlusBetaOnly", systemImage: "line.horizontal.3.decrease.circle.fill") |
There was a problem hiding this comment.
This localized string does not exist
| "ReleaseOnly" = "Release only"; | ||
| "Beta" = "Beta"; | ||
| "BetaOnly" = "Beta only"; | ||
| "ReleasePlusNewBetas" = "Release & New Betas"; |
There was a problem hiding this comment.
I think I like this one better - the only word is kind of redundant
|
Thanks for looking it over! I'm not sure how I ended up committing the wrong enum names and localization keys there, sorry about that! |
# Conflicts: # Xcodes/Resources/en.lproj/Localizable.strings
|
Fixed merge conflicts for Xcodes 2 update |
# Conflicts: # Xcodes/Backend/Version+.swift # Xcodes/Frontend/XcodeList/MainToolbar.swift # Xcodes/Frontend/XcodeList/XcodeListView.swift
|
Fixed merge conflicts for latest version 4.0.2 |
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "Release & New Betas" | ||
| "value" : "Release & unreleased beta" |
There was a problem hiding this comment.
Still not sure the best wording for this if you have better suggestions!
2 participants
This adds a new filter option that shows only releases, plus any betas that do not have a release version. So as of today (July 7, 2023 the Xcode 15 betas will be shown but the Xcode 14 betas won't. Note that this will also show betas for older Xcode versions if necessary, for example if an Xcode 14.3.2 beta is released it will be shown until the mainline Xcode 14.3.2 is released.
This is an implementation for the ideas discussed in #334
I do find the name "Releases & New Betas" to be a little long/wordy, both in the UI and in code. I'm open to suggestions for more succinct names. This also introduces new strings that will need to be localized.