Skip to content

fix: validate credentialStatus format only at sign, not verify #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rongquan1 merged 1 commit into from
Jul 29, 2026
Merged

fix: validate credentialStatus format only at sign, not verify #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/w3c-vc/src/lib/helper/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,15 @@ export function _checkCredential<T extends VerifiableCredential>(
}
}

// Validate credentialStatus field if present
assertCredentialStatuses(credential, mode);
// Validate the credentialStatus field FORMAT only when signing. At verify time the
// credential status is the concern of the dedicated status verifier (verifyCredentialStatus):
// a malformed status field (e.g. a non-integer tokenNetwork.chainId) must surface there as a
// status problem, NOT make the credential look unsigned or fail signature integrity. Note
// that _checkCredential(mode: 'verify') is reached by isSignedDocument() and the
// DataIntegrity verifiers, so throwing here would mis-attribute a status error to those.
if (mode === 'sign') {
assertCredentialStatuses(credential, mode);
}

// Validate that certain fields, if present, are objects with a type property
for (const prop of mustHaveType) {
Expand Down
Loading