fix: validate credentialStatus format only at sign, not verify - #106
Merged
rongquan1 merged 1 commit intoJul 29, 2026
Merged
Conversation
_checkCredential ran assertCredentialStatuses in both 'sign' and 'verify' modes. Since 2.4.0's assertTransferableRecords strictly requires an integer chainId (via assertIntegerChainId), a malformed tokenNetwork.chainId now throws during verify — and _checkCredential(mode: 'verify') is reached by isSignedDocument() and the DataIntegrity verifiers. That made a credential-status field problem masquerade as "document is not signed" / a signature-integrity failure. Gate the credentialStatus field-format validation to 'sign' mode. At verify the status is the concern of the dedicated status verifier (verifyCredentialStatus), so a malformed chainId now surfaces as a DOCUMENT_STATUS problem instead of a signature one. Sign-time validation is unchanged (still rejects a bad chainId at creation). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesCredential status validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
manishdex25
approved these changes
Jul 29, 2026
nghaninn
pushed a commit
that referenced
this pull request
Jul 29, 2026
## [2.4.1](https://github.com/TrustVC/w3c/compare/@trustvc/w3c-vc@2.4.0...@trustvc/w3c-vc@2.4.1) (2026-07-29) ### Bug Fixes * validate credentialStatus format only at sign, not verify ([#106](#106)) ([ade0b3e](ade0b3e))
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nghaninn
pushed a commit
that referenced
this pull request
Jul 29, 2026
## [2.4.1](https://github.com/TrustVC/w3c/compare/@trustvc/w3c@2.4.0...@trustvc/w3c@2.4.1) (2026-07-29) ### Bug Fixes * validate credentialStatus format only at sign, not verify ([#106](#106)) ([ade0b3e](ade0b3e))
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit