Skip to content

fix: make complete family update transactional #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuliusHenke merged 1 commit into from
May 20, 2026
+5 −2
Merged

fix: make complete family update transactional #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/src/main/kotlin/org/tormap/service/RelayDetailsUpdateService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.tormap.service

import org.springframework.jdbc.support.incrementer.PostgresSequenceMaxValueIncrementer
import org.springframework.stereotype.Service
import org.springframework.transaction.support.TransactionTemplate
import org.tormap.database.entity.RelayDetails
import org.tormap.database.repository.RelayDetailsRepositoryImpl
import org.tormap.util.addFamilyMember
Expand All @@ -11,7 +12,6 @@ import org.tormap.util.logger
import javax.sql.DataSource
import javax.transaction.Transactional


/**
* This service deals with [RelayDetails] entities
*/
Expand All @@ -21,6 +21,7 @@ class RelayDetailsUpdateService(
private val ipLookupService: IpLookupService,
private val cacheService: CacheService,
private val coalesceService: CoalesceService,
private val transactionTemplate: TransactionTemplate,
dataSource: DataSource,
) {
private val logger = logger()
Expand Down Expand Up @@ -87,7 +88,9 @@ class RelayDetailsUpdateService(
logger.info("... Updating relay families for months: {}", months.joinToString(", "))
months.forEach { month ->
coalesceService.submitAsync("computeFamilies-$month") {
computeFamiliesForMonth(month)
transactionTemplate.executeWithoutResult {
computeFamiliesForMonth(month)
}
}
}
}
Expand Down
Loading