fix: make complete family update transactional#485
Merged
Conversation
This mitigates an issue where previous family data would be cleared, while the later update of the families might not pass leaving it in a state with empty family data.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes relay family recomputation atomic per-month by ensuring the “clear existing families” step and the subsequent re-save happen within the same database transaction, preventing months from ending up with empty family data if the update fails mid-way.
Changes:
- Inject
TransactionTemplateintoRelayDetailsUpdateService. - Wrap each
computeFamiliesForMonth(month)execution (run viaCoalesceService.submitAsync) in a transaction usingtransactionTemplate.executeWithoutResult { ... }.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mitigates an issue where previous family data would be cleared, while the later update of the families might not pass leaving it in a state with empty family data.