Conversation
purepani
reviewed
Apr 24, 2025
purepani
left a comment
purepani
left a comment
Collaborator
There was a problem hiding this comment.
Feel free to merge without addressing this comment since it can be addressed in a follow-up PR if needed(and I feel like I'm imposing my will on this process a bit too much)
casperdcl
requested review from
gfardell and
paskino
and removed request for
a team
This reverts commit 3d9d9e3.
Member
Author
|
just waiting for a Windows user to test this PR before merging :) |
Member
|
Works with my system IPP and with conda-env ipp on windows. |
gfardell
approved these changes
Apr 29, 2025
casperdcl
added a commit
that referenced
this pull request
Apr 30, 2025
* simple `FindIPP` fallback * enable `find_package` using `*_ROOT` hints * simplified `cilacc` build logic for optional dependencies
casperdcl
added a commit
that referenced
this pull request
Apr 30, 2025
* simple `FindIPP` fallback * enable `find_package` using `*_ROOT` hints * simplified `cilacc` build logic for optional dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FindIPP.cmakeusing default CMake pathsconda/pip/apt/system etc)IPP_ROOTin lieu ofIPP_{INCLUDE,LIBRARY}