Conversation
2907599 to
71bb164
Compare
purepani
left a comment
There was a problem hiding this comment.
There are sort of 3 separate tasks that need to be done in some order:
- switch to nanobind or pybind11 or similar
- simplify IPP library discovery
- switch to scikit-build
I was attacking it from the perspective that it would be easier to do 1 and 2 before 3(and I probably unnecessarily mixed up CI changes into there). This PR attacks it by doing 2 and 3 together.
How hard would it be to just simplify IPP library discovery in 1 PR? That seems like the simplest unit to change here, at least to me.
|
Oh I just realized - are you not doing the build with scikit-build-core yet? Perhaps making that tiny change in a separate PR in anticipation is a good idea to minimize conflict issues. Edit: OH I see what's happening; the python package is being built by cmake itself, whereas I just had the c code being built by cmake, which is needed since you're not building a c-extension but a normal shared library |
|
After attempting it myself, it might just be easier to do all 3 at once(at least for me). I don't personally have the cmake knowledge to do the steps separately, and using scikit-build-core makes it way simpler. |
6c8ece0 to
6f78f05
Compare
|
currently trying to test |
e793b42 to
cf378e4
Compare
scikit-build-coreto drivecmakeWrappers/Python/CMakeLists.txtworkflow_dispatch#2160testing
pip uninstall cil ; rm $CONDA_PREFIX/lib/*cilacc.*)open follow-up issues
intel-openmp,ipp#2154datasubmodule upgrade build framework #1875 (related: data env var #2162)