Skip to content

Fix unsubstituted '%s' in error message for 'for' loop missing 'in' #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobias-Kohn merged 1 commit into from
Aug 3, 2026
Merged

Fix unsubstituted '%s' in error message for 'for' loop missing 'in' #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tpParser/shared/src/main/scala/tigerpython/parser/parsing/Parser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,10 @@ class Parser(val source: CharSequence,
parserState.reportError(line.startPos, ErrorCode.FOREIGN_SYNTAX, "Pascal")
return null
} else {
parserState.reportError(tokens, ErrorCode.TOKEN_REQUIRED, "in")
if (tokens.hasNext)
parserState.reportError(tokens, ErrorCode.TOKEN_REQUIRED, "in")
else
parserState.reportError(tokens.endPos, ErrorCode.MISSING_TOKEN, "in")
if (expressionParser.firstOfTest(tokens))
expressionParser.parseTestListAsTuple(tokens)
else
Expand Down
3 changes: 3 additions & 0 deletions tpParser/shared/src/test/programs/erroneous/for_loop_04.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# 1
# MISSING_TOKEN
for x
2 changes: 2 additions & 0 deletions tpParser/shared/src/test/scala/TestErroneousPrograms.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,7 @@ class TestErroneousPrograms extends FunSuite {
}
assert(cs.get.line+1 == line_no)
assert(cs.get.errorCode.toString == error_msg)
// The error message must have all of its '%s' placeholders substituted with actual values
assert(!cs.get.errorMessage.contains("%s"), s"un-substituted placeholder in message: ${cs.get.errorMessage}")
}
}
Loading