Fix unsubstituted '%s' in error message for 'for' loop missing 'in' - #46
Merged
Tobias-Kohn merged 1 commit intoAug 3, 2026
Merged
Conversation
When a for-statement's target is not followed by 'in' and there are no
more tokens on the line (e.g. just 'for x'), ParserState.reportError's
TokenBuffer overload reports TOKEN_REQUIRED with only one of its two
required parameters, since the auto-padding logic in _reportError is
bypassed once the token stream is exhausted. String.format then throws
and the raw template ('%s' required but '%s' found.) is shown verbatim.
Report MISSING_TOKEN instead in that case, matching the same convention
already used by TokenBuffer.requireType for an exhausted token stream.
Owner
|
Brilliant, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in Strype if you just type "for" on a line, you see this literal message: "'%s' required but '%s' found.". This tiny PR fixes that.
More detail: When a for-statement's target is not followed by 'in' and there are no more tokens on the line (e.g. just 'for x' or just 'for'), ParserState.reportError's TokenBuffer overload reports TOKEN_REQUIRED with only one of its two required parameters, since the auto-padding logic in _reportError is bypassed once the token stream is exhausted. String.format then throws and the raw template ('%s' required but '%s' found.) is shown verbatim.
Report MISSING_TOKEN instead in that case, matching the same convention already used by TokenBuffer.requireType for an exhausted token stream.