Skip to content

Patch 1 - #44

Merged
Tobias-Kohn merged 5 commits into
Tobias-Kohn:masterfrom
sm8ps:patch-1
Jul 28, 2026
Merged

Tobias-Kohn merged 5 commits into
Tobias-Kohn:masterfrom
sm8ps:patch-1

Conversation

@sm8ps

@sm8ps sm8ps commented Jul 26, 2026

Copy link
Copy Markdown
Contributor
  1. Added missing error messages in German according to English and French messages.
  2. Changed message for EXTRA_LINE_NUMBERS in French according to English message and meaning of error code.

sm8ps added 4 commits July 26, 2026 18:16
Add missing error messages by translating the respective messages from the English and French versions.
typo corrected (missing assignment)
Corrected meaning of message for EXTRA_LINE_NUMBER according to EnglishMessages.scala and meaning of error code.
Fixed minor typo (double space).
@Tobias-Kohn

Copy link
Copy Markdown
Owner

Thank you very much for the additions.

If you could please replace the tabulators with space characters, I would be happy to merge the pull request.

However, note that some of the error messages you added are deprecated and obsolete, i.e. they will never actually appear.

Replaced tabs by spaces.
@sm8ps

sm8ps commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Glad to hear you accept my pull request. Editing on Github seems to automatically have turned spaces around '=>' into tabs. I changed them offline.

As for some messages being obsolete, I did not dive into the logic of the error types but started from ErrorCode.scala and worked with the available localisations. So I hope my translations do reflect the proper semantics.

Thanks again for this incredibly valuable piece of software! I intend to combine it with Moodle to automate testing of beginner-level programming courses. For years, I have used TigerJython for this purpose (via ch.aplu.turtle) but the installation was literally drowned by a flash-flood. In the course of re-writing the code I am moving away from Java to Python3 but still wanted to maintain the helpful error messages from TigerJython.

@Tobias-Kohn
Tobias-Kohn merged commit 7a9c7e6 into Tobias-Kohn:master Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants