feat: add numerical laplace transform#14602
Open
Tushar-R-Tyagi wants to merge 5 commits intoTheAlgorithms:masterfrom
Open
feat: add numerical laplace transform#14602Tushar-R-Tyagi wants to merge 5 commits intoTheAlgorithms:masterfrom
Tushar-R-Tyagi wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
Author
|
pre-commit.ci autofix |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a numerical (sampled-data) Laplace transform implementation to the maths/ algorithms collection.
Changes:
- Introduces
laplace_transform()that applies an exponential kernel and integrates via the trapezoidal rule. - Adds doctest examples for two basic reference functions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+44
| if s_value < 0: | ||
| raise ValueError("s_value must be non-negative for convergence.") |
There was a problem hiding this comment.
The convergence check if s_value < 0: raise ... is not generally correct for the Laplace transform (e.g., for f(t)=e^{-t}, the transform converges for Re(s) > -1). Also, since this implementation integrates over a finite sampled window, negative s_value won't inherently diverge. Consider removing this restriction, or (if you keep it) documenting it as a deliberate limitation rather than a convergence requirement.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
I have added a numerical implementation of the Laplace transform in the maths/ directory.
Checklist: