fix(daemon): add Windows autostart management - #397
Open
legend91019 wants to merge 1 commit into
Open
legend91019 wants to merge 1 commit into
legend91019 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #337.
Adds per-user Windows logon autostart management for the foreground BrowserSkill daemon and documents the daemon idle-exit behavior.
What changed
bsk daemon install-autostart.bsk daemon uninstall-autostart.bsk daemon start --foreground.Verification
cargo test -p bsk --test cli_parse parses_daemon_autostart_commands— passed.cargo test -p bsk daemon_autostart— passed; 3 autostart unit tests passed.cargo fmt --all -- --check— passed.cargo build --workspace --locked— passed with existing unused-parameter warnings infile_transfer.rs.cargo clippy --workspace --all-targets --locked -- -D warnings— blocked by existing warnings infile_transfer.rsandskill_install/harness.rs; the new autostart module produced no clippy errors.The detailed Chinese review dossier is maintained locally at
D:\Desktop\open_coding\pr_reviews\Tencent__BrowserSkill__337.md.Scope
The implementation is Windows-only for autostart installation. Other platforms return an explicit unsupported-platform error. No protocol or browser-extension behavior is changed.