Skip to content

fix(rest): modify a channel with PATCH rather than POST #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikield merged 1 commit into from
Sep 2, 2026
Merged

fix(rest): modify a channel with PATCH rather than POST #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rest/Channel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function get(string $channelId): PromiseInterface
public function modify(string $channelId, ChannelBuilder $channel, ?string $reason = null): PromiseInterface
{
return $this->mapPromise(
$this->http->post(
$this->http->patch(
Endpoint::bind(
Endpoint::CHANNEL,
$channelId
Expand Down
10 changes: 5 additions & 5 deletions tests/Rest/ChannelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public static function httpBindingsProvider(): array
'method' => 'modify',
'args' => ['::channel id::', new GuildTextChannelBuilder()],
'mockOptions' => [
'method' => 'post',
'method' => 'patch',
'return' => (object) [],
],
'validationOptions' => [
Expand All @@ -152,7 +152,7 @@ public static function httpBindingsProvider(): array
'method' => 'modify',
'args' => ['::channel id::', new GuildAnnouncementChannelBuilder()],
'mockOptions' => [
'method' => 'post',
'method' => 'patch',
'return' => (object) [],
],
'validationOptions' => [
Expand All @@ -163,7 +163,7 @@ public static function httpBindingsProvider(): array
'method' => 'modify',
'args' => ['::channel id::', new GuildStageVoiceChannelBuilder()],
'mockOptions' => [
'method' => 'post',
'method' => 'patch',
'return' => (object) [],
],
'validationOptions' => [
Expand All @@ -174,7 +174,7 @@ public static function httpBindingsProvider(): array
'method' => 'modify',
'args' => ['::channel id::', new GuildForumChannelBuilder()],
'mockOptions' => [
'method' => 'post',
'method' => 'patch',
'return' => (object) [],
],
'validationOptions' => [
Expand All @@ -185,7 +185,7 @@ public static function httpBindingsProvider(): array
'method' => 'modify',
'args' => ['::channel id::', new GuildVoiceChannelBuilder()],
'mockOptions' => [
'method' => 'post',
'method' => 'patch',
'return' => (object) [],
],
'validationOptions' => [
Expand Down