fix(rest): modify a channel with PATCH rather than POST - #11
Merged
Merged
Conversation
Modify Channel is PATCH /channels/{channel.id}. Sending POST meant every
rename, move between categories and permission change made through
Channel::modify() was refused by Discord, so nothing that edits a channel
after creating it has ever worked.
The test covering it asserted the verb the implementation happened to use
rather than the one the API documents, so it passed throughout.
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify Channel is
PATCH /channels/{channel.id}.Channel::modify()sentPOST, so every rename, move between categories and permission change made through it was refused by Discord — nothing that edits a channel after creating it has ever worked.Found while porting a bot that archives ticket channels by renaming them and moving them into another category: the calls went out and silently did nothing.
The five
modifycases inChannelTestassertedpost, i.e. the verb the implementation happened to use rather than the one the API documents, so the suite stayed green over the bug. They now assertpatch.I checked the rest of the REST layer for the same class of mistake —
updateRecords,editChannelPermissions,modifyMfaLevel,modifyOnboardingandeditApplicationCommandPermissionsare all documented as PUT or POST and are correct as they stand. This is the only one.🤖 Generated with Claude Code