Repository navigation
fix(node): flush queued events in short-lived processes (#843) - #848
Merged
Merged
Conversation
…#843); node 1.4.2, core 1.5.2 (unpublished)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #843.
@telemetry-tracker/core1.5.2: newflush()(sends the queue, awaits in-flight batch requests, never rejects) andpendingEventCount(). Batching timer unchanged.@telemetry-tracker/node1.4.2: exportsasync flush(); registers abeforeExithandler that flushes only when events are queued (no exit loop), plus a best-effortexithandler that warns when events are still queued (e.g. afterprocess.exit()).job.mjsdelivers 2/2 with no sleep,await flush(); process.exit(0)delivers, long-running process still batches on the interval.await flush(), each noting it requires Node SDK >= 1.4.2.