SharedDesignSystem 토큰/컴포넌트 기반 추가 - #10
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (33)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (26)
📝 WalkthroughSummary by CodeRabbit
WalkthroughSharedDesignSystem에 색상·숫자·타이포그래피 토큰, 공개 접근 API, 버튼·텍스트·소셜 로그인 컴포넌트, 폰트 등록, 테스트와 DEBUG 갤러리를 추가했습니다. Changes디자인 시스템 기반
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant AppBootstrap
participant DesignSystemFontRegistration
participant SharedDesignSystem
AppBootstrap->>DesignSystemFontRegistration: registerIfNeeded()
DesignSystemFontRegistration->>SharedDesignSystem: Pretendard 리소스 검색 및 등록
SharedDesignSystem-->>DesignSystemFontRegistration: 등록 성공 여부
DesignSystemFontRegistration-->>AppBootstrap: Bool 반환
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ARCHITECTURE.md`:
- Around line 64-65: docs/ARCHITECTURE.md의 두 shared design system 링크가 존재하지 않는
문서를 가리키고 있습니다. 실제 문서를 유효한 경로에 추가하고 링크를 그 경로로 갱신하거나, 문서가 필요하지 않다면 해당 링크 항목을 삭제해
깨진 참조가 남지 않도록 하세요.
In
`@Projects/Shared/DesignSystem/Sources/Components/Button/DesignButtonSize.swift`:
- Around line 19-48: Define button-specific numeric tokens in SemanticNumber for
the horizontal padding and icon sizes, then update
DesignButtonSize.horizontalPadding and iconSize to use those tokens instead of
literal values. Preserve the existing size-specific values and leave
cornerRadius unchanged.
In
`@Projects/Shared/DesignSystem/Sources/Components/Button/DesignButtonStyle.swift`:
- Around line 147-188: Update DesignButtonChromeStyle to read
`@Environment`(\.isEnabled) and have resolvedState use that environment value, so
ancestor .disabled(true) selects the disabled tokens. In DesignButton, stop
passing isEnabled into the style while preserving .disabled(!isEnabled); add a
regression test covering an ancestor .disabled(true) state.
In `@Projects/Shared/DesignSystem/Sources/Preview/DesignSystemGallery.swift`:
- Around line 35-37: Remove the DesignSystemFontRegistration.registerIfNeeded()
call from the DesignSystemGallery onAppear handler, keeping font registration
exclusively in the App bootstrap flow. If Preview font registration is required,
move it to a Preview-only host rather than performing bootstrap work from the
shared view.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b4e5042-927e-4e8d-a65c-4eea959f8277
⛔ Files ignored due to path filters (10)
Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Contents.jsonis excluded by!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Social/Contents.jsonis excluded by!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Social/icon_social_apple.imageset/Apple.svgis excluded by!**/*.svg,!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Social/icon_social_apple.imageset/Contents.jsonis excluded by!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Social/icon_social_kakao.imageset/Contents.jsonis excluded by!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Assets.xcassets/Icon/Social/icon_social_kakao.imageset/Kakao.svgis excluded by!**/*.svg,!**/*.xcassets/**Projects/Shared/DesignSystem/Resources/Fonts/Pretendard-Bold.otfis excluded by!**/*.otfProjects/Shared/DesignSystem/Resources/Fonts/Pretendard-Medium.otfis excluded by!**/*.otfProjects/Shared/DesignSystem/Resources/Fonts/Pretendard-Regular.otfis excluded by!**/*.otfProjects/Shared/DesignSystem/Resources/Fonts/Pretendard-SemiBold.otfis excluded by!**/*.otf
📒 Files selected for processing (32)
Projects/App/Sources/DI/AppBootstrap.swiftProjects/Shared/DesignSystem/Project.swiftProjects/Shared/DesignSystem/Sources/Access/CGFloat+DesignSystem.swiftProjects/Shared/DesignSystem/Sources/Access/Color+DesignSystem.swiftProjects/Shared/DesignSystem/Sources/Access/Font+DesignSystem.swiftProjects/Shared/DesignSystem/Sources/Components/Button/DesignButton.swiftProjects/Shared/DesignSystem/Sources/Components/Button/DesignButtonSize.swiftProjects/Shared/DesignSystem/Sources/Components/Button/DesignButtonStyle.swiftProjects/Shared/DesignSystem/Sources/Components/Button/DesignButtonVariant.swiftProjects/Shared/DesignSystem/Sources/Components/Social/SocialLoginButton.swiftProjects/Shared/DesignSystem/Sources/Components/Social/SocialLoginProvider.swiftProjects/Shared/DesignSystem/Sources/Components/Text/DesignText.swiftProjects/Shared/DesignSystem/Sources/Foundation/Color+Hex.swiftProjects/Shared/DesignSystem/Sources/Foundation/FontRegistration.swiftProjects/Shared/DesignSystem/Sources/Placeholder.swiftProjects/Shared/DesignSystem/Sources/Preview/DesignSystemGallery.swiftProjects/Shared/DesignSystem/Sources/Tokens/Primitive/PrimitiveColor.swiftProjects/Shared/DesignSystem/Sources/Tokens/Primitive/PrimitiveNumber.swiftProjects/Shared/DesignSystem/Sources/Tokens/Semantic/SemanticColor.swiftProjects/Shared/DesignSystem/Sources/Tokens/Semantic/SemanticNumber.swiftProjects/Shared/DesignSystem/Sources/Tokens/Typography/TextStyle.swiftProjects/Shared/DesignSystem/Sources/Tokens/Typography/Typography.swiftProjects/Shared/DesignSystem/Tests/Components/DesignButtonMetricsTests.swiftProjects/Shared/DesignSystem/Tests/Components/SocialLoginProviderTests.swiftProjects/Shared/DesignSystem/Tests/Foundation/FontRegistrationTests.swiftProjects/Shared/DesignSystem/Tests/Smoke/SharedDesignSystemSmokeTests.swiftProjects/Shared/DesignSystem/Tests/Tokens/PrimitiveColorTests.swiftProjects/Shared/DesignSystem/Tests/Tokens/SemanticColorTests.swiftProjects/Shared/DesignSystem/Tests/Tokens/SemanticNumberTests.swiftProjects/Shared/DesignSystem/Tests/Tokens/TypographyTests.swiftdocs/ARCHITECTURE.mddocs/CONVENTIONS.md
💤 Files with no reviewable changes (1)
- Projects/Shared/DesignSystem/Sources/Placeholder.swift
gnoes-ios
force-pushed
the
feat/shared-design-system
branch
from
August 4, 2026 07:04
ef20eb5 to
6c030c8
Compare
gnoes-ios
force-pushed
the
feat/shared-design-system
branch
from
August 4, 2026 07:36
6c030c8 to
3d75846
Compare
This was referenced Aug 4, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 변경 요약
📌 변경 내용
SharedDesignSystem Tokens
TextStyle토큰 추가Color.ds/Font.ds/CGFloat.ds/TextStyle.ds추가Color.ds.social.*) 정리SharedDesignSystem Components
DesignText공통 텍스트 컴포넌트 추가DesignButtonvariant/size/state 골격 추가SocialLoginButton및 Kakao/Apple provider 추가icon_social_kakao,icon_social_apple) 추가Font / App
DesignSystemFontRegistration및 App bootstrap 1회 등록 경로 추가Preview / Test / Docs
DesignSystemGallery추가docs/ARCHITECTURE.md,docs/CONVENTIONS.mdDesignSystem 사용 규칙 반영