로그인 게이트 UI와 라우팅 추가 - #13
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
Walkthrough부트스트랩 이후 앱 흐름을 세션 복원 결과에 따라 Changes인증 게이트 라우팅
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant AppCoordinatorView
participant AppCoordinatorFeature
participant AuthClient
participant LoginFeature
participant OnboardingPlaceholderFeature
AppCoordinatorView->>AppCoordinatorFeature: onAppear
AppCoordinatorFeature->>AuthClient: restoreSession()
AuthClient-->>AppCoordinatorFeature: AuthSession 또는 AuthError
AppCoordinatorFeature->>AppCoordinatorFeature: login, onboarding 또는 main 상태 설정
LoginFeature->>AuthClient: login(provider)
AuthClient-->>LoginFeature: AuthSession 또는 AuthError
LoginFeature-->>AppCoordinatorFeature: delegate loggedIn(AuthSession)
OnboardingPlaceholderFeature->>AuthClient: logout()
AuthClient-->>OnboardingPlaceholderFeature: 성공 또는 AuthError
OnboardingPlaceholderFeature-->>AppCoordinatorFeature: delegate loggedOut
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Projects/Feature/Sources/AppCoordinator/AppCoordinatorFeature.swift`:
- Around line 132-164: Update bootstrapIfNeeded and handleBootstrapResponse to
track whether restoreSession is already in progress, set that state when
starting the request, and ignore duplicate onAppear triggers while it is active.
Only apply a bootstrap response when the corresponding restore request is still
pending, then clear the pending state before transitioning to login or the main
screen; add a reducer test that sends onAppear twice before the response and
verifies restoreSession runs once.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 2babb9e0-aa69-4e97-98cd-9a06a8e687fd
📒 Files selected for processing (12)
AGENTS.mdProjects/Feature/README.mdProjects/Feature/Sources/AppCoordinator/AppCoordinatorFeature.swiftProjects/Feature/Sources/AppCoordinator/AppCoordinatorView.swiftProjects/Feature/Sources/Scene/Login/LoginFeature.swiftProjects/Feature/Sources/Scene/Login/LoginView.swiftProjects/Feature/Sources/Scene/OnboardingPlaceholder/OnboardingPlaceholderFeature.swiftProjects/Feature/Sources/Scene/OnboardingPlaceholder/OnboardingPlaceholderView.swiftProjects/Feature/Tests/AppCoordinator/AppCoordinatorFeatureTests.swiftProjects/Feature/Tests/Login/LoginFeatureTests.swiftProjects/Feature/Tests/OnboardingPlaceholder/OnboardingPlaceholderFeatureTests.swiftdocs/ARCHITECTURE.md
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 변경 요약
📌 변경 내용
Feature
Scene/Login로그인 UI 및AuthClient.login연동 추가Scene/OnboardingPlaceholder온보딩 placeholder 및 로그아웃 흐름 추가AppCoordinatorFeaturephase를 login / onboarding / main 으로 확장profileCompleted기준 진입 분기 연결Tests
Docs
AGENTS.md,ARCHITECTURE.md, Feature README 런타임 흐름 문서 갱신