Repository navigation
fix(ui): give dark-mode pages the header's gridded night band - #45
Conversation
In dark mode the page ground (#111416, blue-grey) did not match the header's near-black band and its faint grid, so every page looked like a different surface from the navbar. - Dark --bg is now #0a0a0a, the header's --head-bg. - New --page-grid token (transparent in light, --head-grid in dark) drawn on body with the header's 3.5rem grid. - Body, header and dashboard hero grids are fixed to the window so the lines meet while the page scrolls. - Light mode is unchanged. - e2e: body and header share colour and grid in dark mode; differ in light. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e9b6e3e29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| linear-gradient(var(--page-grid) 1px, transparent 1px), | ||
| linear-gradient(90deg, var(--page-grid) 1px, transparent 1px); | ||
| background-size: 3.5rem 3.5rem; | ||
| background-attachment: fixed; |
There was a problem hiding this comment.
Keep the grid aligned in iOS Safari
On iOS Safari, background-attachment: fixed is ignored—as the added HO-116 entry itself records—so after scrolling a long signed-in page, the body grid moves with the document while the sticky header's grid remains positioned with the header, recreating the seam this change is intended to remove. The new assertion runs only in the configured Desktop Chrome project, so it cannot catch this phone-specific regression; use an alignment technique that does not depend on fixed backgrounds or provide a Safari fallback.
AGENTS.md reference: AGENTS.md:L183-L183
Useful? React with 👍 / 👎.
Resolve the HANDOFF conflict: main took HO-116 to HO-118, so this branch's entry becomes HO-119 after them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
|
Deployment failed for project reeflect with the following error: Learn More: https://vercel.com/tahubcs-projects?upgradeToPro=build-rate-limit |
A UI audit found pages that looked like different apps: - Dark greys were blue-grey next to the neutral header (left over from #45, which merged before that commit was pushed). - Pages used six widths, some centred, and Budgets had no side padding (text touched the screen edge on phones). - A bare h1 rule meant for the dashboard made Bills and Recurring titles 3rem while others were 2.5rem. - Input borders were about 1.3:1 against cards (WCAG 1.4.11 asks 3:1). - Focus rings came in three colours, buttons in five shapes, with no hover states; the selected Bills tab was 1.04:1. Tokens now carry the frame (--gutter, --page-top, --page-narrow/medium/ wide), field borders (--field-line) and corners (--radius-control, --radius-card). Pages are left-aligned under the header, share one title style, use the global focus ring, and every button has a hover state.
Summary
In dark mode, every signed-in page had a blue-grey background (
#111416) that didn't match the header's near-black band (#0a0a0a) or its faint grid. Pages now use the header's colour and grid, so the header and page look like one surface.--bgis now#0a0a0a, the same as--head-bg.--page-gridtoken istransparentin light mode and--head-gridin dark mode.bodydraws it with the header's 3.5rem grid.background-attachment: fixed, so the lines meet where the header ends and stay lined up while the page scrolls.Feature / bug
UI inconsistency between the header and page background (F-18 themes)
Governing ADRs
ADR-046 (plain CSS, tokens in
globals.css)Type
Definition of done (AGENTS.md section 8)
tests/e2e/app-nav.spec.ts: in dark mode, body and header have the same colour, grid, size and attachment; in light mode the colours differ)Database
Security impact
None. CSS and an e2e test only.
Screenshots
Dark mode, desktop: the header and page now share the near-black, gridded background. The committed screenshots in
docs/screenshots/still show the old background; they regenerate the next time their specs run.🤖 Generated with Claude Code
https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx