Skip to content

fix(ui): give dark-mode pages the header's gridded night band - #45

Merged
TahubCS merged 2 commits into
mainfrom
claude/confident-lamport-14r5fp
Oct 11, 2026
Merged

TahubCS merged 2 commits into
mainfrom
claude/confident-lamport-14r5fp

Conversation

@TahubCS

@TahubCS TahubCS commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

In dark mode, every signed-in page had a blue-grey background (#111416) that didn't match the header's near-black band (#0a0a0a) or its faint grid. Pages now use the header's colour and grid, so the header and page look like one surface.

  • Dark --bg is now #0a0a0a, the same as --head-bg.
  • A new --page-grid token is transparent in light mode and --head-grid in dark mode. body draws it with the header's 3.5rem grid.
  • The body, sticky header and dashboard hero grids use background-attachment: fixed, so the lines meet where the header ends and stay lined up while the page scrolls.
  • Light mode is unchanged: light grey pages under the dark header band.

Feature / bug

UI inconsistency between the header and page background (F-18 themes)

Governing ADRs

ADR-046 (plain CSS, tokens in globals.css)

Type

  • feat
  • fix
  • refactor
  • test
  • docs
  • chore / ci

Definition of done (AGENTS.md section 8)

  • Follows every non-negotiable rule in AGENTS.md section 4
  • Vitest tests for domain logic, including edge cases (no domain logic changed)
  • Playwright test for the user-facing flow (tests/e2e/app-nav.spec.ts: in dark mode, body and header have the same colour, grid, size and attachment; in light mode the colours differ)
  • Workspace isolation matrix updated if a new server action or route was added (none added)
  • Lint, typecheck, unit and E2E pass locally: lint, format:check, typecheck, docs:check and build pass. The e2e suite is left for the author to run.
  • Docs updated; HANDOFF entry appended (HO-119; main had already taken HO-116 to HO-118)

Database

  • No schema change
  • Schema change with generated migration included (describe below)

Security impact

None. CSS and an e2e test only.

Screenshots

Dark mode, desktop: the header and page now share the near-black, gridded background. The committed screenshots in docs/screenshots/ still show the old background; they regenerate the next time their specs run.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx

In dark mode the page ground (#111416, blue-grey) did not match the
header's near-black band and its faint grid, so every page looked like a
different surface from the navbar.

- Dark --bg is now #0a0a0a, the header's --head-bg.
- New --page-grid token (transparent in light, --head-grid in dark) drawn
  on body with the header's 3.5rem grid.
- Body, header and dashboard hero grids are fixed to the window so the
  lines meet while the page scrolls.
- Light mode is unchanged.
- e2e: body and header share colour and grid in dark mode; differ in light.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
reeflect Ready Ready Preview Oct 11, 2026 1:28pm UTC

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: TahubCS/Reeflect/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f1270b0c-272a-4dc4-8de1-f2b34862219d

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T13:30:10.065808Z 6e9b6e3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e9b6e3e29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/app/globals.css
linear-gradient(var(--page-grid) 1px, transparent 1px),
linear-gradient(90deg, var(--page-grid) 1px, transparent 1px);
background-size: 3.5rem 3.5rem;
background-attachment: fixed;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the grid aligned in iOS Safari

On iOS Safari, background-attachment: fixed is ignored—as the added HO-116 entry itself records—so after scrolling a long signed-in page, the body grid moves with the document while the sticky header's grid remains positioned with the header, recreating the seam this change is intended to remove. The new assertion runs only in the configured Desktop Chrome project, so it cannot catch this phone-specific regression; use an alignment technique that does not depend on fixed backgrounds or provide a Safari fallback.

AGENTS.md reference: AGENTS.md:L183-L183

Useful? React with 👍 / 👎.

Resolve the HANDOFF conflict: main took HO-116 to HO-118, so this
branch's entry becomes HO-119 after them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BPCHu3hWdkxC3xHAxPegqx
@vercel

vercel Bot commented Oct 11, 2026

Copy link
Copy Markdown

Deployment failed for project reeflect with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/tahubcs-projects?upgradeToPro=build-rate-limit

@JacobGittHub JacobGittHub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TahubCS
TahubCS merged commit 50aa9ee into main Oct 11, 2026
7 of 8 checks passed
TahubCS added a commit that referenced this pull request Oct 11, 2026
A UI audit found pages that looked like different apps:
- Dark greys were blue-grey next to the neutral header (left over from
  #45, which merged before that commit was pushed).
- Pages used six widths, some centred, and Budgets had no side padding
  (text touched the screen edge on phones).
- A bare h1 rule meant for the dashboard made Bills and Recurring titles
  3rem while others were 2.5rem.
- Input borders were about 1.3:1 against cards (WCAG 1.4.11 asks 3:1).
- Focus rings came in three colours, buttons in five shapes, with no
  hover states; the selected Bills tab was 1.04:1.

Tokens now carry the frame (--gutter, --page-top, --page-narrow/medium/
wide), field borders (--field-line) and corners (--radius-control,
--radius-card). Pages are left-aligned under the header, share one title
style, use the global focus ring, and every button has a hover state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants