Skip to content

Remove unused UI kit and preserve review evidence - #42

Merged
sdcarlson merged 6 commits into
mainfrom
cursor/mvp-review-loop
Sep 6, 2026
Merged

sdcarlson merged 6 commits into
mainfrom
cursor/mvp-review-loop

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

The unused generated UI kit added dependencies and maintenance work without serving Relay screens. This PR now removes that kit, its unused helper/hook and Next configuration, and the unused Tailwind pipeline. Runtime history, session guards, CSV, assistant handoffs and copy/paste remain exactly as merged in #36. It also restores the historical PR24 evidence accidentally omitted during consolidation, with original commit/test-count limits intact.

The original review-loop fixes are already on main through #15/#36; this final delta does not replace their implementations. No database migration or deployment change.

Validation against main 7cfec26: typecheck, lint, frozen offline lockfile validation, all98 unit tests, release build and six browser journeys pass. The prior combined API run passed before choosing the unchanged main runtime; fresh hosted API/production/security checks are required on this pushed head. Dependencies were removed without disabling audit or CI gates.

Remove the unused shadcn/Next leftovers that never rendered in Relay.
Keep the job-history contract: user-scoped records, exact acceptance,
and imports that cannot grant approval.

A 401 now clears private workspace state and ignores stale responses.
Selecting a job loads that job's review events beyond the global 200.
Packets and draft results work for valid jobs without a posting URL.

Closes #7
Closes #8
Closes #9

Co-authored-by: Seth Carlson <sdcarlson@users.noreply.github.com>
@cursor cursor Bot mentioned this pull request Sep 6, 2026
4 of 6 tasks
# Conflicts:
#	app/workspace.tsx
#	integrations/README.md
#	lib/workspace-refresh.ts
#	tests/workspace-refresh.test.mjs
# Conflicts:
#	app/workspace.tsx
#	package.json
#	pnpm-lock.yaml
#	tests/api.test.mjs
#	tests/obsidian.test.mjs
sdcarlson pushed a commit that referenced this pull request Sep 6, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Problem and result

Closes #8
Closes #9
Closes #19

`main` already includes protected CI/CD (#14), context playbooks (#18),
session-expiry (#15 / #7), ChatGPT/Codex public-copy (#13), Apache 2.0
(#39 / #38), and tracker CSV (#11 / #17). This branch merges that tip
and keeps the remaining unique trees:

- Local-dev Node/port/sign-in, with a Windows-safe Node guard instead of
Bash (#12 / #19)
- Copy/paste draft handoffs, exact-acceptance actions, and
dirty-navigation guards (#24)
- Selected-job review history beyond the GET 200-event window (#8)
- Assistant packets for valid jobs with `url: null` (#9)
- Canonical public-copy listing for Tracker CSV (the #11 squash kept
that note outside the maintained block)

Head `4d8f007` merges `origin/main` (`256854b`, #11) into the previous
landing. Conflict resolution kept `void test` wrappers, history/null-URL
API coverage, and one Tracker CSV setup section.

The changes-requested review is on superseded `9e307b9`. Independent
preservation review of `8d6ba1a` retired the five original code
findings. These merges do not restore them.

Deferred, matching maintainer comments, and **not** in this PR:

- Profile calibration loop (#26)
- `shadcn` 4.20.1 (#32)
- Production 503 diagnostics (#22 / draft #40)
- Assistant research/next-task handoff (#37 / #41) — stacked on landed
#13, not this consolidation
- Unused UI-kit cut / competing review-loop draft (#42)

Keep #16 open: remaining development-tool advisories. Keep #21 open
until post-merge Pages verification. Keep #22 open. Cloudflare hosting
(#3), two-account isolation (#4), recruiting (#5), backup rehearsal
(#6), and Grok Bot VM command review (#20) still need human/environment
work.

## Evidence

- Local on `4d8f007`: `pnpm lint`, `pnpm typecheck`, `pnpm test` (98
passed), `pnpm public-copy:check`, `pnpm build`, `pnpm test:api`, `pnpm
test:e2e` (6 passed), `pnpm test:production` passed.
- GitHub CI on `4d8f007` ([run
34003847782](https://github.com/SyberLabs/relay/actions/runs/34003847782)):
quality, API, browser, production, CodeQL, dependency-security, and
bundled agent contracts were running or already green after this merge;
required `CI` still needs the remaining jobs.
- User-visible proof: copy/paste packet, Windows-safe
`scripts/ensure-node.mjs`, Load earlier review history, null-URL
packets. CSV import and ChatGPT/Codex prepare now come from `main`.
- Security, data migration, and rollback impact: no new D1 migration.
React trio stays at 19.2.8. CI Vinext still uses ephemeral ports when
`RELAY_CI_STATE` is set. Production integration keeps the original
request sequence.

## Review

- [ ] One issue owns this scope; unrelated changes are separate. This is
an explicit integration PR covering the remaining open merge train.
- [x] Tests exercise the changed behavior, including failure paths
(including compiled Workspace continuation and history-after-expiry
regressions).
- [x] No credentials, personal applications, or private research are
included.
- [x] Agent findings from the `9e307b9` review remain addressed.
- [ ] A maintainer other than the author will approve. **@sdcarlson must
approve the latest push** (`4d8f007`); prior reviews do not cover this
merge commit.
- [x] Public capabilities, integration limits and lead-engineer credit
match `docs/public-copy.json`; run `pnpm public-copy:check` and follow
`docs/PUBLIC-COPY.md` when these change.

After merge, close the superseded feature PRs (#12, #24) as landed here
rather than squash-merging them separately. #11, #13, #15, and #39 are
already merged. #26 and #32 stay closed as deferred. #40, #41, and #42
stay on their own tracks.

<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-3877d527-b5e4-46d7-8c5f-573418309ece?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-3877d527-b5e4-46d7-8c5f-573418309ece&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
# Conflicts:
#	app/api/workspace/route.ts
#	app/connections.tsx
#	app/workspace.tsx
#	integrations/connectors.mjs
#	lib/integration-files.ts
#	pnpm-lock.yaml
#	tests/refresh-expiry.test.mjs
#	tests/workspace-events.test.mjs
#	tests/workspace-refresh.test.mjs
#	vite.config.ts
@sdcarlson sdcarlson changed the title Cut unused UI kit and fix the review-loop defects Remove unused UI kit and preserve review evidence Sep 6, 2026
@sdcarlson
sdcarlson requested a review from sykosyber September 6, 2026 01:29
@sdcarlson
sdcarlson marked this pull request as ready for review September 6, 2026 01:30
@sdcarlson
sdcarlson enabled auto-merge (squash) September 6, 2026 01:30
@cursor

cursor Bot commented Sep 6, 2026

Copy link
Copy Markdown

@sykosyber review needed now.

This is the tonight-deploy PR. Main already has the review-loop fixes. #42 is the remaining first-principles cut: delete the unused shadcn/Next kit that never rendered in Relay. No schema change. No product-behavior change. CI is on the rebased head.

Please approve and squash-merge so we can ship the actual workspace, not a component library.

If you see a real product-contract break, comment with file/line. Otherwise this is ready.

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

No actionable defects on bcfb3b9779ca8688d906377f4ea3de92b9a204b0 (still PR head at post time).

This delta deletes the unused UI kit and its unused Next/Tailwind wiring, then restores historical PR24 evidence in REVIEW.md. Runtime auth, workspace mutations, exact acceptance, stale-update guards, migrations, and workflows are unchanged versus main 7cfec26.

Inspected (this review): git diff 7cfec26...bcfb3b9 (70 files); remaining imports of deleted @/components/ui, @/lib/utils, @/hooks/use-mobile, @/ aliases, and removed npm packages (none); app className usage vs app/globals.css (custom classes, not Tailwind utilities); empty deleted next.config.ts; lockfile importers vs package.json and unchanged lockfile overrides; no workflow/migration/API file changes; prior review threads (none); AGENTS.md + docs/threat-model.md.

Observed, not re-run here: GitHub checks on this head — Quality and release build, Integration (api), Integration (production), Dependency security, Bundled agent contracts, Security/CodeQL: SUCCESS. Integration (browser) was still in progress. I did not execute PR code or tests locally.

Human approval remains mandatory. This review does not grant merge or deploy authority.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (head bcfb3b9779ca8688d906377f4ea3de92b9a204b0)

No actionable defects on this head. This is a deletion/config cleanup plus restored historical REVIEW.md notes. It does not change identity, owner-scoped writes, exact acceptance, stale-update guards, migrations, workflows, or release provenance. Human approval remains mandatory.

Scope actually inspected

  • Triple-dot diff vs 7cfec262 (70 files; +51 / −11114). Non-deletion edits: package.json, pnpm-lock.yaml, tsconfig.json, vite.config.ts, app/globals.css, REVIEW.md.
  • Deleted next.config.ts was an empty Next stub. Deleted lib/utils.ts / hooks/use-mobile.ts / components.json / components/ui/* have no remaining importers.
  • Ripgrep on this checkout: no leftover @/ aliases, cn(), Tailwind/@apply directives, or imports of the removed UI-kit packages. Remaining screens use custom classes already defined in app/globals.css (shell, sidebar, primary, …). lucide-react is still imported by app/workspace.tsx and kept.
  • No db/, app/api/, workspace/auth/editor, .github/, or migration files in the delta. REVIEW.md additions are historical QA notes (scoped to old SHAs) and do not include credentials.
  • Rechecked PR head and prior review threads immediately before posting: head unchanged; no prior automation threads.

Checks run vs only inspected

Ran (read-only): gh pr view / reviews / threads / checks; git diff / git show of changed and deleted helpers; targeted ripgrep; read docs/threat-model.md and the surviving config/CSS.

Did not run: unit tests, lint/typecheck/build, browser journeys, or any PR application code. No secrets used.

Inspected CI on this head (not re-executed): Quality and release build, Bundled agent contracts, Dependency security, Integration (api), Integration (production), and CodeQL reported pass. Still pending at review time: Integration (browser) and the Security/CodeQL job.

No inline findings.

Open in Web View Automation 

Sent by Cursor Automation: RELAY pull request review

@cursor

cursor Bot commented Sep 6, 2026

Copy link
Copy Markdown

@sykosyber CI is fully green on bcfb3b9. Required CI check passed. Cursor review found no defects. Required gate left: your approval.

Approve + squash-merge #42. Tonight’s artifact should be the review workspace, not 11k lines of unused UI.

@sdcarlson

Copy link
Copy Markdown
Contributor Author

Final head bcfb3b9 now passes every hosted check, including quality/build, API, browser, production, CodeQL, dependency security and automated review. Local98unit/build/sixbrowser/type/lint/frozenlock checks also passed. Application behavior matches merged main7cfec262; final diff removes unused UI/dependencies and restores historical review evidence. Ready for sykosyber latest-head approval; protected squash auto-merge is enabled.

@sykosyber sykosyber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partner Extra High review of bcfb3b9779ca8688d906377f4ea3de92b9a204b0.

Independent of the High Fast comments on this SHA. Unique delta vs current main (7cfec262) deletes the unused UI kit (components/ui/*, components.json, hooks/use-mobile.ts, lib/utils.ts, empty next.config.ts), removes the unused Tailwind/@/* wiring from app/globals.css, vite.config.ts, tsconfig.json, and package.json/pnpm-lock.yaml, and restores historical PR24 notes in REVIEW.md. I grepped this head for leftover @/, components/ui, lib/utils, hooks/use-mobile, and Tailwind package imports: none. lucide-react remains and is still used by app/workspace.tsx. No app/api, auth, editor, migration, or workflow files change. Runtime history, session guards, CSV, copy/paste, and exact acceptance stay as landed in #36.

Required CI is green on this head, including Quality, Integration (api/browser/production), Dependency security, Bundled agent contracts, and CodeQL: run 34004037056. This approval is for this commit only and does not merge or deploy.

@sdcarlson
sdcarlson merged commit 007e0ae into main Sep 6, 2026
10 checks passed
@sdcarlson
sdcarlson deleted the cursor/mvp-review-loop branch September 6, 2026 01:33
sdcarlson added a commit that referenced this pull request Sep 6, 2026
Closes #37.

Users can now select and edit one job's research and specify the next
drafting task inside the existing Prepare for ChatGPT/Codex downloads.
Research stays separate from candidate facts, optional fields clear on
job changes, oversized context is rejected, and returned drafts retain
explicit review and stale-version checks. No migration, dependencies,
provider service, or submission behavior changes.

Reconciled onto current main007e0ae after #13, #36 and #42 merged.
Canonical copy/paste, exact editor checks, selected-job packet creation
and history remain intact. Production remains blocked by owner setup in
#3 and the normal staging/peer production approval gates.

Validation: lint, typecheck, 99 unit tests, public-copy check, build,
API suite, all 6 Chromium journeys (context returns by paste and file),
and compiled production/gateway smoke passed locally. High-severity
dependency audit passed; inherited development-tool esbuild advisories
remain (one moderate via drizzle-kit, one low via Wrangler), with no
dependency changes in this PR.

A fictional two-model smoke trial ran one history/focused/checkpoint
condition each for gpt-5.4-mini and gpt-5.5. All six used supported
facts without invented qualifications or submission claims. One draft
included an internal review note; a prompt refinement and one repeat
corrected it. The committed report records limitations: not blinded, no
repeated benchmark, no model ranking/cost claim, and no native
compaction test.

Recovery: revert this UI/prompt change; stored job data and packet
schemas are unchanged. Real-user validation remains separate from these
fictional checks.

Latest headfe73858 is rebased onto main007e0ae with an unchanged context
diff. Local lint/types/99 unit tests/build pass; fresh integration and
hosted checks are running. Earlier production503 evidence remains in
#22; this change does not claim a fix. Final peer approval and green
current-head CI are required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants