Repository navigation
Delete code no deployed app reaches: harnesses, examples, jev_api, unused symbols - #166
Merged
Merged
Conversation
…used symbols Live roots: the Docker image (syberwork CLI) and the syberlabs CLI, plus what CI gates need. benchmarks: adversarial_payment, build_thread_dx, evolve_baseline, run_bench, model_vs_patch syberlabs/jev_api.py (its only caller was model_vs_patch) examples: critic_model, githits_ab, pilot_rehearsal, repair syberlabs/metrics.py: provenance, WorkItemMetrics.index syberlabs/search.py: Candidate.promotion_reason syberlabs/build.py: search.strict (written, never read) Tests that covered only the above, stale comments, unused imports and locals, durations entries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…fixtures benchmarks/run_bench.py and test_short_benchmark_stays_under_a_dev_ceiling come back: the test is the only latency ceiling on admit, Session and Work, and run_bench is its driver. Found by an independent review. tests/fixtures/jev_api had no reader once jev_api was removed. The metrics docstring no longer names provenance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 2, 2026
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Delete code no live deployed app can reach
Class: R
Agent-platform: claude@opus-5.5
Admitted-by: self (Class R)
Evidence: tested
Scope
The owner's definition: a path is dead if no live deployed app can reach it. Nothing in this repository is a standing deployment today (
docs/DEPLOY.md), so the owner chose these live roots: the Docker image (syberworkserve, worker, init, backup, restore) and thesyberlabsCLI, which CI's admit job runs on every pull request.Removed (48 files changed, 4933 lines removed, 27 added)
benchmarks/:adversarial_payment.py,build_thread_dx.py,evolve_baseline.py,model_vs_patch.pysyberlabs/jev_api.py(its only caller wasmodel_vs_patch) andtests/fixtures/jev_api/examples/:critic_model.py,githits_ab.py,pilot_rehearsal.py,repair.pysyberlabs/metrics.py:provenance,WorkItemMetrics.index;syberlabs/search.py:Candidate.promotion_reason;syberlabs/build.py:search.stricttests/durations.jsonentriesKept on purpose, though the live roots do not reach them
scripts/g*.py,syberlabs/attest_reconcile_map.py,examples/attest_receipt_observe.py,conformance/,syberwork/smoke.py.AGENTS.md:examples/reference_system.py,case_studies/.syberlabs/dashboard.pyandrefusals.py. G5 protects a sentence indocs/DASHBOARD.mdthat describes the dashboard's escaping.scripts/pilot_dry_run.py(MasterMind's pilot preregistration),examples/attest_dispatch.py(SyberLabs/attest).conformance.clean_install:examples/release_gate.py,access_review.py,build_thread.py,evolve.py.examples/critic_rules.py,metric_source.py.benchmarks/run_bench.py, the driver of the only latency ceiling onadmit,SessionandWork.syberlabs/protocol.pytypes,BuilderStoremethods,Work.register_principal,submit_witness,Candidate.authoritative.Needs a key holder: stale references left in place
AGENTS.md(Models section, Class X example) andREADME.mdline 22 still namebenchmarks/model_vs_patch.py.spec/GAPS.mdhas 12 mentions of removed names. None of these three were edited.Also stale:
docs/EVOLUTION.md,E3_BENCHMARK_PLAN.md,PAID_PROBLEM.md,CRITIC.md,EXPERIMENTS.md,ADVERSARIAL_BENCHMARK.md,ROADMAP_STATUS.md,AUTOSKILL.md,BUILD_THREAD.md,CLAUDE_CODE.md,EVAL.md,GITHITS.md,SDK_FEEDBACK.md.docs/MODEL_COMPARISON.mdgained a note pointing at commit8a5e21f. Recorded results inbenchmarks/results/stay, since docs cite them.Open pull requests
No open pull request edits a removed file. #163 mentions reusing
jev_api's request and validation code in a later packet (prose only, no import); it would restore the module from8a5e21f. #154 and #164 listsyberlabs/jev_api.pyin a factory path map, which needs dropping when they rebase.Review
An independent session that did not write this change tried to prove each deletion wrong and found nothing still reaching removed code. It found the lost latency guard, a stale docstring and the orphaned fixtures, all fixed here.
Reviewed-by: independent Claude session (subagent, claude@opus-5.5)
Claim ceiling: tested
Local, macOS, CPython 3.12.16, from a clean worktree at the head commit:
scripts/run_shards.py --floor origin/main: 1209 tests, OK (skipped=23, expected failures=5); floor: all 1269 base tests here or excused by the diff. Base onmain: 1269 tests, OK (same skips).python -m conformance.run: matched 23 golden traces (no trace changes).node --test tests/console_model.test.mjs: 32 pass, 1 skipped.python -m conformance.clean_install: passes.Not run locally: PostgreSQL, Windows, 3.11/3.13, Compose (CI covers these). Sibling repositories were searched at their
originrefs as last fetched locally, and SyberLabs through GitHub code search, which was rate limited before the last lookups.🤖 Generated with Claude Code