Skip to content

Delete code no deployed app reaches: harnesses, examples, jev_api, unused symbols - #166

Merged
sdcarlson merged 2 commits into
mainfrom
claude/dead-code-aggressive
Nov 2, 2026
Merged

sdcarlson merged 2 commits into
mainfrom
claude/dead-code-aggressive

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Objective: Delete code no live deployed app can reach

Class: R
Agent-platform: claude@opus-5.5
Admitted-by: self (Class R)
Evidence: tested

Scope

The owner's definition: a path is dead if no live deployed app can reach it. Nothing in this repository is a standing deployment today (docs/DEPLOY.md), so the owner chose these live roots: the Docker image (syberwork serve, worker, init, backup, restore) and the syberlabs CLI, which CI's admit job runs on every pull request.

Removed (48 files changed, 4933 lines removed, 27 added)

  • benchmarks/: adversarial_payment.py, build_thread_dx.py, evolve_baseline.py, model_vs_patch.py
  • syberlabs/jev_api.py (its only caller was model_vs_patch) and tests/fixtures/jev_api/
  • examples/: critic_model.py, githits_ab.py, pilot_rehearsal.py, repair.py
  • syberlabs/metrics.py: provenance, WorkItemMetrics.index; syberlabs/search.py: Candidate.promotion_reason; syberlabs/build.py: search.strict
  • Tests that covered only the above (60 fewer tests), stale comments, unused imports and locals, 31 tests/durations.json entries

Kept on purpose, though the live roots do not reach them

  • CI gates and what they need (changing a gate is Class C): scripts/g*.py, syberlabs/attest_reconcile_map.py, examples/attest_receipt_observe.py, conformance/, syberwork/smoke.py.
  • Named keep-green in AGENTS.md: examples/reference_system.py, case_studies/.
  • Protected requirement text: syberlabs/dashboard.py and refusals.py. G5 protects a sentence in docs/DASHBOARD.md that describes the dashboard's escaping.
  • External callers: scripts/pilot_dry_run.py (MasterMind's pilot preregistration), examples/attest_dispatch.py (SyberLabs/attest).
  • Used by conformance.clean_install: examples/release_gate.py, access_review.py, build_thread.py, evolve.py.
  • Test fixtures for live code, or touched by open pull requests: examples/critic_rules.py, metric_source.py.
  • Latency guard on live paths: benchmarks/run_bench.py, the driver of the only latency ceiling on admit, Session and Work.
  • Test-only but described by frozen spec or used as test setup: syberlabs/protocol.py types, BuilderStore methods, Work.register_principal, submit_witness, Candidate.authoritative.

Needs a key holder: stale references left in place

AGENTS.md (Models section, Class X example) and README.md line 22 still name benchmarks/model_vs_patch.py. spec/GAPS.md has 12 mentions of removed names. None of these three were edited.

Also stale: docs/EVOLUTION.md, E3_BENCHMARK_PLAN.md, PAID_PROBLEM.md, CRITIC.md, EXPERIMENTS.md, ADVERSARIAL_BENCHMARK.md, ROADMAP_STATUS.md, AUTOSKILL.md, BUILD_THREAD.md, CLAUDE_CODE.md, EVAL.md, GITHITS.md, SDK_FEEDBACK.md. docs/MODEL_COMPARISON.md gained a note pointing at commit 8a5e21f. Recorded results in benchmarks/results/ stay, since docs cite them.

Open pull requests

No open pull request edits a removed file. #163 mentions reusing jev_api's request and validation code in a later packet (prose only, no import); it would restore the module from 8a5e21f. #154 and #164 list syberlabs/jev_api.py in a factory path map, which needs dropping when they rebase.

Review

An independent session that did not write this change tried to prove each deletion wrong and found nothing still reaching removed code. It found the lost latency guard, a stale docstring and the orphaned fixtures, all fixed here.

Reviewed-by: independent Claude session (subagent, claude@opus-5.5)

Claim ceiling: tested

Local, macOS, CPython 3.12.16, from a clean worktree at the head commit:

  • scripts/run_shards.py --floor origin/main: 1209 tests, OK (skipped=23, expected failures=5); floor: all 1269 base tests here or excused by the diff. Base on main: 1269 tests, OK (same skips).
  • python -m conformance.run: matched 23 golden traces (no trace changes).
  • node --test tests/console_model.test.mjs: 32 pass, 1 skipped.
  • python -m conformance.clean_install: passes.

Not run locally: PostgreSQL, Windows, 3.11/3.13, Compose (CI covers these). Sibling repositories were searched at their origin refs as last fetched locally, and SyberLabs through GitHub code search, which was rate limited before the last lookups.

🤖 Generated with Claude Code

…used symbols

Live roots: the Docker image (syberwork CLI) and the syberlabs CLI, plus what CI gates need.

benchmarks: adversarial_payment, build_thread_dx, evolve_baseline, run_bench, model_vs_patch
syberlabs/jev_api.py (its only caller was model_vs_patch)
examples: critic_model, githits_ab, pilot_rehearsal, repair
syberlabs/metrics.py: provenance, WorkItemMetrics.index
syberlabs/search.py: Candidate.promotion_reason
syberlabs/build.py: search.strict (written, never read)
Tests that covered only the above, stale comments, unused imports and locals, durations entries

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T11:11:23.828849Z 563d105 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…fixtures

benchmarks/run_bench.py and test_short_benchmark_stays_under_a_dev_ceiling come back: the test is the only
latency ceiling on admit, Session and Work, and run_bench is its driver. Found by an independent review.
tests/fixtures/jev_api had no reader once jev_api was removed. The metrics docstring no longer names provenance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant