Skip to content

Delete more code no deployed app reaches: submit_witness, unused alias, orphan baselines - #169

Merged
sdcarlson merged 2 commits into
mainfrom
claude/dead-code-pass-3
Nov 3, 2026
Merged

sdcarlson merged 2 commits into
mainfrom
claude/dead-code-pass-3

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Objective: Delete more code no live deployed app can reach (a follow-up to #166)

Class: R
Agent-platform: claude@opus-5.5
Admitted-by: self (Class R)
Evidence: tested

Removed

  • Session.submit_witness, Work.submit_witness: only a test called them. The console's Work.request_witness is the live path. tests/test_external_witness.py now calls the witness client directly, so it still checks the signature stays out of the history.
  • The console sentence in syberwork/static/app.js that told scripts to call the removed method. This is a visible text change on a live page.
  • syberlabs/query_guard.py: the CREDENTIAL alias and the one test assertion on it. The same test still pins _patterns.SECRET.
  • conformance/baseline/: nothing reads these two files.
  • A one-line note on 15 docs pages saying named code may have been removed. Measured claims on those pages are unchanged.

How the candidates were found

Three signals on syberlabs and syberwork: vulture with tests, examples and benchmarks not counted as callers; a name-based reachability walk from the kept roots, which also catches dead clusters; and line coverage of the suite. Everything else they flagged was checked and is live or held back below.

Held back

  • assess_integrity's host and verifier paths, IntegrityVerifier, record_host_integrity, bind_evaluation, record_bound_evaluation: deployed callers never use them, but they are the mechanisms behind the verified classes in the frozen spec/BUILDER.md and the Builder schemas. Removing them is a spec-level decision.
  • Work.register_principal: no deployed caller, yet server.py still looks principals up. Removing it would mean deciding what cell principals are, not deleting an unused function.

Review

An independent session that did not write this change found nothing still reaching the removed code, and that request_witness keeps the chain check. It found two doc lines still presenting submit_witness as available, corrected here.

Reviewed-by: independent Claude session (subagent, claude@opus-5.5)

Claim ceiling: tested

Local, macOS, CPython 3.12.16, clean worktree, before the final docs-only commit: scripts/run_shards.py --floor origin/main 1220 tests, OK (skipped=23, expected failures=5), floor satisfied with no test removed; python -m conformance.run matched 23 golden traces; node --test tests/console_model.test.mjs 32 pass, 1 skipped; python -m conformance.clean_install passes. PostgreSQL, Windows, 3.11/3.13 and Compose are left to CI.

🤖 Generated with Claude Code

…s, orphan baselines

syberlabs/session.py, syberwork/core.py: submit_witness (only a test called it; the console's request_witness is the live path). The external witness test calls the client directly.
syberwork/static/app.js: the console sentence that told scripts to call it
syberlabs/query_guard.py: the CREDENTIAL alias
conformance/baseline: nothing reads these files
docs: a note on pages that name removed code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T05:50:06.233703Z 5c9d7e7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sdcarlson
sdcarlson force-pushed the claude/dead-code-pass-3 branch from 6dba9d1 to eb25f38 Compare November 3, 2026 05:51
@sdcarlson
sdcarlson merged commit f953b95 into main Nov 3, 2026
25 checks passed
@sdcarlson
sdcarlson deleted the claude/dead-code-pass-3 branch November 3, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant