Repository navigation
Delete more code no deployed app reaches: submit_witness, unused alias, orphan baselines - #169
Merged
Merged
Conversation
…s, orphan baselines syberlabs/session.py, syberwork/core.py: submit_witness (only a test called it; the console's request_witness is the live path). The external witness test calls the client directly. syberwork/static/app.js: the console sentence that told scripts to call it syberlabs/query_guard.py: the CREDENTIAL alias conformance/baseline: nothing reads these files docs: a note on pages that name removed code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sdcarlson
force-pushed
the
claude/dead-code-pass-3
branch
from
November 3, 2026 05:51
6dba9d1 to
eb25f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective: Delete more code no live deployed app can reach (a follow-up to #166)
Class: R
Agent-platform: claude@opus-5.5
Admitted-by: self (Class R)
Evidence: tested
Removed
Session.submit_witness,Work.submit_witness: only a test called them. The console'sWork.request_witnessis the live path.tests/test_external_witness.pynow calls the witness client directly, so it still checks the signature stays out of the history.syberwork/static/app.jsthat told scripts to call the removed method. This is a visible text change on a live page.syberlabs/query_guard.py: theCREDENTIALalias and the one test assertion on it. The same test still pins_patterns.SECRET.conformance/baseline/: nothing reads these two files.How the candidates were found
Three signals on
syberlabsandsyberwork: vulture with tests, examples and benchmarks not counted as callers; a name-based reachability walk from the kept roots, which also catches dead clusters; and line coverage of the suite. Everything else they flagged was checked and is live or held back below.Held back
assess_integrity'shostandverifierpaths,IntegrityVerifier,record_host_integrity,bind_evaluation,record_bound_evaluation: deployed callers never use them, but they are the mechanisms behind the verified classes in the frozenspec/BUILDER.mdand the Builder schemas. Removing them is a spec-level decision.Work.register_principal: no deployed caller, yetserver.pystill looks principals up. Removing it would mean deciding what cell principals are, not deleting an unused function.Review
An independent session that did not write this change found nothing still reaching the removed code, and that
request_witnesskeeps the chain check. It found two doc lines still presentingsubmit_witnessas available, corrected here.Reviewed-by: independent Claude session (subagent, claude@opus-5.5)
Claim ceiling: tested
Local, macOS, CPython 3.12.16, clean worktree, before the final docs-only commit:
scripts/run_shards.py --floor origin/main1220 tests, OK (skipped=23, expected failures=5), floor satisfied with no test removed;python -m conformance.runmatched 23 golden traces;node --test tests/console_model.test.mjs32 pass, 1 skipped;python -m conformance.clean_installpasses. PostgreSQL, Windows, 3.11/3.13 and Compose are left to CI.🤖 Generated with Claude Code