Repository navigation
Fail GitHits lookups closed before the network unless a valid guard decision exists, and add a hooked API lane (api-hooked) so --githits only runs where the PreToolUse guard runs - #155
Conversation
… decision; add the api-hooked lane, refuse --githits with --bare, and a default GitHits deny-list SyberLabs-Thread: 6c983f71-04ce-469b-b9cf-5cdad1478205 SyberLabs-Candidate: c2 SyberLabs-Provider: claude@opus-5.5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Handoff: Build Thread What changed
Evidence
Claim ceiling. Implemented and tested against the stand-in
Publishing note: the first No paid model or real GitHits API was called. The owner merges. 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1211d08c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 2. The primary metric and the group the decision rests on (for example: the delivery rule on `needs_lookup` items, with `--delivered review`). | ||
| 3. The exclusion rules: the nine excluded checks above, and nothing else. | ||
| 4. The frozen setup: the SyberWork commit, Claude Code version, model, effort, `--allowed-tools`, `--max-turns`, the query guard's thresholds, the credential lane, and arm B's GitHits route (`--githits`) with its license policy (`SYBERLABS_GITHITS_LICENSES`, recorded as `signal.githits.license_policy`). Use the `api` lane (`--bare`) in both arms: it is the lane whose cost is billed and known, and in bare mode the tree's `CLAUDE.md` is not read in either arm. The contract prices every model the runs report (`evolution.budget.prices`); a run that used a model the contract does not price has an unknown cost. Anything that learns from runs stays off for the week. AutoSkill is a design (`docs/AUTOSKILL.md`) and is in no proposer path; the `jev` and `empirical` branch policies belong to `--evolve`, which the pilot does not use. | ||
| 4. The frozen setup: the SyberWork commit, Claude Code version, model, effort, `--allowed-tools`, `--max-turns`, the query guard's thresholds, the credential lane, and arm B's GitHits route (`--githits`) with its license policy (`SYBERLABS_GITHITS_LICENSES`, recorded as `signal.githits.license_policy`). Use the `api-hooked` lane (`--lane api-hooked --trusted-tree`) in both arms: the API key, so the cost is billed and known, without `--bare`, because Claude Code 2.1.312 runs no `--settings` hook under `--bare` and the provider refuses `--githits` there (`docs/CLAUDE_CODE.md`, the hooked API lane); each call gets an empty config directory and home. Not in bare mode, the tree's `CLAUDE.md` is read, equally in both arms: record it with the conditions. The contract prices every model the runs report (`evolution.budget.prices`); a run that used a model the contract does not price has an unknown cost. Anything that learns from runs stays off for the week. AutoSkill is a design (`docs/AUTOSKILL.md`) and is in no proposer path; the `jev` and `empirical` branch policies belong to `--evolve`, which the pilot does not use. |
There was a problem hiding this comment.
Update the pilot commands to use the hooked API lane
The following “Each item, each arm” commands still use --bare, and arm B combines it with --githits. This commit makes --githits with --bare fail with invalid_provider, so readers following the pilot instructions cannot run it; update both commands to use --lane api-hooked --trusted-tree.
Useful? React with 👍 / 👎.
Independent verification of #155 (
|
Objective: Fail GitHits lookups closed before the network unless a valid guard decision exists, and add a hooked API lane (api-hooked) so --githits only runs where the PreToolUse guard runs
Class: R
Agent-platform: claude@opus-5.5
Admitted-by: sykosyber
Reviewed-by: rules@2 (critic check critic.rules: high 0, medium 0, low 0)
Evidence: tested
Accepted in SyberLabs thread
6c983f71-04ce-469b-b9cf-5cdad1478205as candidatec2(commitc1211d08c8f270c2fd161bbc48cfd9bb6334024f).Host checks on that tree: conformance passed, critic.rules passed, scenarios passed, tests passed.