Repository navigation
Close the follow-ups from PR #155's verifier: refuse unscreened --bare lookups (MCP servers, WebSearch, WebFetch) unless an explicit recorded override is given, stop Git Bash rewriting launcher argume - #162
Conversation
…ash rewriting launcher arguments, mirror lane refusals in eval spec validation, fix docs digest and a flaky pace test SyberLabs-Thread: b4b760bd-a5dc-4ca5-abfc-db9772103579 SyberLabs-Candidate: c1 SyberLabs-Provider: claude@opus-5.5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Handoff: packet What changed. Scratch CI on the exact trees (branches pushed only for this, not PR heads).
Host evaluation (unattended Certificate. Publishing. 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c13da728
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def example(request): | ||
| arrivals.append(time.time()) | ||
| slots.append(githits_pace._last(stamp_file)) # the slot the arriving request took (the latest stamp) |
There was a problem hiding this comment.
Capture each request's slot separately
If a process is paused after wait() stamps its slot and the next process takes another slot before the first request arrives, _last() reads the newer shared stamp for both requests. The assertion that the recorded slots are at least one interval apart then fails on a slow runner, so this test can remain flaky; record each caller's own slot instead of rereading the shared latest stamp.
Useful? React with 👍 / 👎.
Independent verification of #162 (
|
Objective: Close the follow-ups from PR #155's verifier: refuse unscreened --bare lookups (MCP servers, WebSearch, WebFetch) unless an explicit recorded override is given, stop Git Bash rewriting launcher arguments, mirror the provider's lane refusals in eval spec validation, and fix the stale docstring and skill digest in the docs. Also make the cross-process GitHits pace test robust on slow runners by asserting on recorded stamps instead of wall-clock arrival.
Class: R
Agent-platform: claude@opus-5.5
Admitted-by: sykosyber
Reviewed-by: rules@2 (critic check critic.rules: high 0, medium 0, low 0)
Evidence: tested
Accepted in SyberLabs thread
b4b760bd-a5dc-4ca5-abfc-db9772103579as candidatec1(commit14c13da728efb91ce8c0eb302abc7a9cae1e4c56).Host checks on that tree: conformance passed, critic.rules passed, scenarios passed, tests passed.