Repository navigation
Make the GitHits A/B pilot ready to run: keep permissive-licence examples from GitHits' documented responses, pace example calls host-side to one per 40 s across processes and arms with the wait exclu - #153
Conversation
…es in the licence filter (References/Sources links count as sources; answers with no code pass), pace example calls host-side to on SyberLabs-Thread: e9a369f3-aacf-4522-82bf-2334815d2231 SyberLabs-Candidate: c1 SyberLabs-Provider: claude@opus-5.5
|
Handoff: Build Thread Evidence
No paid model or real GitHits API was called. The owner merges. 🤖 Generated with Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e2a572eea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| temporary.write_text(repr(now), encoding="ascii") | ||
| os.replace(temporary, stamp) |
There was a problem hiding this comment.
Pace from the request start, not the slot reservation
If a launcher is descheduled after writing this slot but before Client.call reaches _send, another process can send at the 40-second mark and reach GitHits less than 40 seconds after the first request—or before a delayed first request. The lock serializes reservations, not request starts, so a stalled launcher can still violate the per-organization rate; pace through request initiation or otherwise account for the actual send time.
Useful? React with 👍 / 👎.
| base=_base(events), objective=_objective(events), server=_servers(registrations, server), | ||
| models=_models(registrations), accepted=accepted, time_to_pass=time_to_pass, | ||
| reviewed=_reviewed(events, accept, commit), work=work, upto=upto, observed=_observed(events, server), | ||
| paced=_paced(events), |
There was a problem hiding this comment.
Bound agent-time pacing to the merge
If a thread records a GitHits example after its PR has merged, this stores pacing from the entire thread, and _per_arm subtracts it from agent_time, which ends at merged_at. That wait was not part of the measured duration, so the report understates agent time (or clamps it to zero); keep the whole-thread total for paced_seconds but subtract only pacing through the merge.
Useful? React with 👍 / 👎.
Independent verification of #153 (
|
Objective: Make the GitHits A/B pilot ready to run: keep permissive-licence examples from GitHits' documented responses, pace example calls host-side to one per 40 s across processes and arms with the wait excluded from agent time, and pin the engineering smoke to Claude Code 2.1.312. The change touches the host launcher path, the GitHits licence filter, the experiment report, the smoke script, their tests and docs, and leaves githits.py's request retry behaviour alone because pilot item SW-01 measures it.
Class: R
Agent-platform: claude@opus-5.5
Admitted-by: sykosyber
Reviewed-by: rules@2 (critic check critic.rules: high 0, medium 0, low 0)
Evidence: tested
Accepted in SyberLabs thread
e9a369f3-aacf-4522-82bf-2334815d2231as candidatec1(commit3e2a572eeafa03cd373e4001a0b2065c1643b6e7).Host checks on that tree: conformance passed, critic.rules passed, scenarios passed, tests passed.